Donatas Abraitis <donatas.abraitis@gmail.com>: Author Summary

Builds triggered by Donatas Abraitis <donatas.abraitis@gmail.com>

Builds triggered by an author are those builds which contains changes committed by the author.
810
344 (42%)
466 (58%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
56 (7% of all builds triggered)
286 (35% of all builds triggered)
230
Build Completed Code commits Tests
FRR › FRRPULLREQ › #10540 1 day ago
Merge pull request #5723 from donaldsharp/73_onlink_loss
73 onlink loss
7170 passed
FRR › FRRPULLREQ › #10527 2 days ago
Merge pull request #5720 from mjstapp/fix_nh_debug_show_7_3
zebra: [7.3] include zebra nexthop debug in show run
7179 passed
FRR › FRRPULLREQ › #10518 4 days ago
Merge pull request #5708 from donaldsharp/nexthop_encoding_73
[7.3]lib: Fix nexthop encoding
7170 passed
FRR › FRRPULLREQ › #10517 4 days ago
Merge pull request #5708 from donaldsharp/nexthop_encoding_73
[7.3]lib: Fix nexthop encoding
2 of 7215 failed
FRR › FRRPULLREQ › #10515 4 days ago
Merge pull request #5656 from pguibert6WIND/import_evpn_entries
bgpd: import evpn entries with nexthop self attribute
7182 passed
FRR › FRR › #2919 4 days ago
Merge pull request #5656 from pguibert6WIND/import_evpn_entries
bgpd: import evpn entries with nexthop self attribute
8281 passed
You have insufficient permissions to see all of the builds.
Build Completed Code commits Tests
FRR › FRR72BUILD › #2 1 week ago
doc: redistribute vpn --> redistribute vnc
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Reflect the distance in RIB when it is changed for an arbitrary afi/safi
debian-9# show ip route 192.168.255.2/32 longer-prefixes
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

B>* 192.168.255.2/32 [20/0] via 192.168.0.1, eth1, 00:15:22
debian-9# conf
debian-9(config)# router bgp 100
debian-9(config-router)# address-family ipv4
debian-9(config-router-af)# distance bgp 123 123 123
debian-9(config-router-af)# do show ip route 192.168.255.2/32 longer-prefixes
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

B>* 192.168.255.2/32 [123/0] via 192.168.0.1, eth1, 00:00:09
debian-9(config-router-af)# no distance bgp
debian-9(config-router-af)# do show ip route 192.168.255.2/32 longer-prefixes
Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued route, r - rejected route

B>* 192.168.255.2/32 [20/0] via 192.168.0.1, eth1, 00:00:02
debian-9(config-router-af)#

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
doc: Append documentation for `bgp dampening` command
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Merge pull request #5387 from donaldsharp/7.2_cherrys
[7.2] cherrys
doc: Add redistribute vnc-direct command
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Notify "Peer De-configured" after entering 'no neighbor <neighbor> cmd'
Before changes:

~# vtysh -c 'show ip bgp neighbors 192.168.0.2 json' | \
        jq '."192.168.0.2".lastNotificationReason'
null

After changes:

~# vtysh -c 'show ip bgp neighbors 192.168.0.2 json' | \
        jq '."192.168.0.2".lastNotificationReason'
"Cease/Peer Unconfigured"

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Show `ip` and `fqdn` in json output for `show [ip] bgp <route> json`
This should keep backward compatibility when bgp show-hostname is
enabled/disabled.

Also show the real originator IP instead of showing fqdn of the route
reflector.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Merge pull request #5642 from slankdev/slankdev-bgpd-fix-large-rd-frr-7-2
bgpd: [7.2] fix large route-distinguisher's format
tests: Test if `distance bgp (1-255) (1-255) (1-255)` works
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Autocomplete neighbor for clear bgp
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
(cherry picked from commit 453c92f6e2a981d024ec3433e804c02bd70f2a13)
bgpd: Rework BGP dampening to be per AFI/SAFI
Before we had:

!
router bgp 65031
 bgp dampening 1 2 3 4
!

exit2-debian-9(config)# router bgp 65031
exit2-debian-9(config-router)# address-family ipv4 multicast
exit2-debian-9(config-router-af)# bgp dampening 5 6 7 8
exit2-debian-9(config-router-af)# end
exit2-debian-9# show running-config

!
router bgp 65031
 bgp dampening 1 2 3 4
!

After fix:

!
router bgp 65031
 neighbor 192.168.1.2 remote-as 100
 !
 address-family ipv4 unicast
  bgp dampening 1 2 3 4
 exit-address-family
 !
 address-family ipv4 multicast
  bgp dampening 5 6 7 8
 exit-address-family
!

exit2-debian-9# show ip bgp ipv4 unicast dampening parameters
Half-life time: 1 min
Reuse penalty: 2
Suppress penalty: 3
Max suppress time: 4 min
Max suppress penalty: 32

exit2-debian-9# show ip bgp ipv4 multicast dampening parameters
Half-life time: 5 min
Reuse penalty: 6
Suppress penalty: 7
Max suppress time: 8 min
Max suppress penalty: 18

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Merge pull request #5173 from opensourcerouting/72-bfdd-vrf-socket
[7.2] bfdd: VRF security improvement
tests: Test if eBGP policy is not applied to iBGP peers
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Merge pull request #5685 from opensourcerouting/7.2/manpage-rename
[7.2] doc: manpage rename
tests: Test if `ip` and `fqdn` are included in `show [ip] bgp json`
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Do not apply eBGP policy for iBGP peers
Treat iBGP peers as they have a policy applied.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Merge pull request #5447 from donaldsharp/7.2_bgp_show_json_mem_leak
[7.2]bgpd: Fix memory leak in json output of show commands
bgpd: Make sure we can use `no bgp listen range ...`
Fixes:
```
exit1-debian-9(config-router)# no bgp listen range 192.168.10.0/24 peer-group TEST
% Peer-group does not exist
exit1-debian-9(config-router)#
```
Closes https://github.com/FRRouting/frr/issues/5570

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Testless build
FRR › FRR › #2899 1 week ago
Merge pull request #5666 from donaldsharp/more_nhg_fixes
bgpd, ospfd, zebra: Do not use 0 as VRF_DEFAULT
6771 passed
FRR › FRR › #2861 2 weeks ago
bgpd: Print pretty json output for bgp_show_table()
This is not very cool:

```
{
 "vrfId": 0,
 "vrfName": "default",
 "tableVersion": 4,
 "routerId": "192.168.0.1",
 "defaultLocPrf": 100,
 "localAS": 200,
 "routes": { "10.0.0.150/32": [{"valid":true,"bestpath":true,"pathFrom":"external","prefix":"10.0.0.150","prefixLen":32,"network":"10.0.0.150\/32","med":0,"metric":0,"weight":32768,"peerId":"(unspec)","aspath":"200 200 200","path":"200 200 200","origin":"incomplete","nexthops":[{"ip":"0.0.0.0","afi":"ipv4","used":true}]}],"10.0.0.200/32": [{"valid":true,"bestpath":true,"pathFrom":"external","prefix":"10.0.0.200","prefixLen":32,"network":"10.0.0.200\/32","med":0,"metric":0,"weight":32768,"peerId":"(unspec)","aspath":"200 200 200","path":"200 200 200","origin":"incomplete","nexthops":[{"ip":"0.0.0.0","afi":"ipv4","used":true}]}],"10.0.2.0/24": [{"valid":true,"bestpath":true,"pathFrom":"external","prefix":"10.0.2.0","prefixLen":24,"network":"10.0.2.0\/24","med":0,"metric":0,"weight":32768,"peerId":"(unspec)","aspath":"200 200 200","path":"200 200 200","origin":"incomplete","nexthops":[{"ip":"0.0.0.0","afi":"ipv4","used":true}]}],"192.168.0.0/24": [{"valid":true,"bestpath":true,"pathFrom":"external","prefix":"192.168.0.0","prefixLen":24,"network":"192.168.0.0\/24","med":0,"metric":0,"weight":32768,"peerId":"(unspec)","aspath":"200 200 200","path":"200 200 200","origin":"incomplete","nexthops":[{"ip":"0.0.0.0","afi":"ipv4","used":true}]}] }  }
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Print json output for show_ip_bgp_regexp_cmd
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Adjust warning message for bgp_show_regexp()
Before it was:
```
exit1-debian-9# show ip bgp regexp ^200a
Invalid character in as-path access-list ^200a
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
7193 passed
FRR › FRR › #2849 3 weeks ago
bgpd: Send notification to the peer on FSM error
We should send a NOTIFICATION message with the Error Code Finite State
Machine Error if we receive NOTIFICATION in OpenSent state
as defined in https://tools.ietf.org/html/rfc4271#section-8.2.2

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd: Change description for `[no] bgp listen limit` commands
It's quite confusing when you see this:
```
exit1-debian-9(config-router)# bgp listen
  listen  Configure BGP defaults
```

And:
```
exit1-debian-9(config-router)# no bgp listen
  listen  unset maximum number of BGP Dynamic Neighbors that can be created
```

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
408 of 8310 failed
You have insufficient permissions to see all of the builds.
Build Completed Code commits Tests
FRR › FRRPULLREQ › #10540 1 day ago
Merge pull request #5723 from donaldsharp/73_onlink_loss
73 onlink loss
7170 passed
FRR › FRRPULLREQ › #10527 2 days ago
Merge pull request #5720 from mjstapp/fix_nh_debug_show_7_3
zebra: [7.3] include zebra nexthop debug in show run
7179 passed
FRR › FRRPULLREQ › #10518 4 days ago
Merge pull request #5708 from donaldsharp/nexthop_encoding_73
[7.3]lib: Fix nexthop encoding
7170 passed
FRR › FRRPULLREQ › #10515 4 days ago
Merge pull request #5656 from pguibert6WIND/import_evpn_entries
bgpd: import evpn entries with nexthop self attribute
7182 passed
FRR › FRRPULLREQ › #10476 1 week ago
Merge pull request #5699 from qlyoung/zebra-iprule-print-unknown-family-as-number
zebra: print unknown rule family as number
7173 passed
FRR › FRRPULLREQ › #10470 1 week ago
Merge pull request #5608 from dslicenc/frr-reload-deletes
tools: improve frr-reload delete performance for some commands
7173 passed
FRR › FRRPULLREQ › #10469 1 week ago
Merge pull request #5608 from dslicenc/frr-reload-deletes
tools: improve frr-reload delete performance for some commands
7170 passed
FRR › FRRPULLREQ › #10467 1 week ago
Merge pull request #5608 from dslicenc/frr-reload-deletes
tools: improve frr-reload delete performance for some commands
7173 passed
FRR › FRRPULLREQ › #10466 1 week ago
Merge pull request #5608 from dslicenc/frr-reload-deletes
tools: improve frr-reload delete performance for some commands
7173 passed
FRR › FRRPULLREQ › #10464 1 week ago
Merge pull request #5608 from dslicenc/frr-reload-deletes
tools: improve frr-reload delete performance for some commands
7173 passed