Marcel Röthke <marcel.roethke@haw-hamburg.de>: Author Summary

Builds triggered by Marcel Röthke <marcel.roethke@haw-hamburg.de>

Builds triggered by an author are those builds which contains changes committed by the author.
113
68 (60%)
45 (40%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
26 (23% of all builds triggered)
5 (4% of all builds triggered)
-21
Build Completed Code commits Tests
RPKI › RTRLIB › #69 1 month ago
rtrlib/rtr: Ensure shadow tables are only freed when initialized (#204)
From the Bug report:
> If rtr_receive_pdu returns an error code, the execution flow is
> redirected to the cleanup label. If ->is_resetting is now true (e.g.,
> because it was set by a CACHE_RESPONSE PDU processed by
> rtr_handle_cache_response_pdu), pfx_table_free_without_notify and
> spki_table_free_without_notify are executing multiple operations on this
> uninitialized data.

This patch ensures the cleanup code can check whether the shadow tables
have been initialized and only frees them if they are.
Testless build
RPKI › RTRLIBPR › #67 1 month ago
rtrlib/rtr: Ensure shadow tables are only freed when initialized (#204)
From the Bug report:
> If rtr_receive_pdu returns an error code, the execution flow is
> redirected to the cleanup label. If ->is_resetting is now true (e.g.,
> because it was set by a CACHE_RESPONSE PDU processed by
> rtr_handle_cache_response_pdu), pfx_table_free_without_notify and
> spki_table_free_without_notify are executing multiple operations on this
> uninitialized data.

This patch ensures the cleanup code can check whether the shadow tables
have been initialized and only frees them if they are.
Testless build
RPKI › RTRLIB › #67 1 month ago
tests: add missing include in test_pfx (#209)
The compiler complained about an implicit function declaration because
of a missing include.
Testless build
RPKI › RTRLIBPR › #66 1 month ago
tests: add missing include in test_pfx (#209)
The compiler complained about an implicit function declaration because
of a missing include.
Testless build
RPKI › RTRLIBPR › #62 1 month ago
rtrlib/lib: Fix ipv4 address conversion on big endian systems (#206)
The current ipv4 address string conversion implementation is not byte
order agnostic, it implicitly assumes little endian by directly working
with the bytes of an 4 Byte integer.

With this patch native bit operations are used instead.
Testless build
RPKI › RTRLIB › #65 1 month ago
rtrlib/lib: Fix ipv4 address conversion on big endian systems (#206)
The current ipv4 address string conversion implementation is not byte
order agnostic, it implicitly assumes little endian by directly working
with the bytes of an 4 Byte integer.

With this patch native bit operations are used instead.
Testless build
RPKI › RTRLIBPR › #61 1 month ago
rtrlib/lib: Fix ipv4 address conversion on big endian systems (#206)
The current ipv4 address string conversion implementation is not byte
order agnostic, it implicitly assumes little endian by directly working
with the bytes of an 4 Byte integer.

With this patch native bit operations are used instead.
Testless build
RPKI › RTRLIBPR › #53 1 month ago
rtrlib: support use in c++ projects (#200)
To support inclusion from c++ projects the name mangling must be
disabled for rtrlib symbols, otherwise the linker can't find them.
Testless build
RPKI › RTRLIB › #63 1 month ago
rtrlib: support use in c++ projects (#200)
To support inclusion from c++ projects the name mangling must be
disabled for rtrlib symbols, otherwise the linker can't find them.
Testless build
RPKI › RTRLIBPR › #52 1 month ago
rtrlib: support use in c++ projects (#200)
To support inclusion from c++ projects the name mangling must be
disabled for rtrlib symbols, otherwise the linker can't find them.
Testless build
Build Completed Code commits Tests
RPKI › RTRLIB › #62 1 month ago
tests: add connect timeout to test_dynamic_groups (#198)
Without a timeout the test will hang indefinitely if for whatever reason
the connection to the cache server can not be established.
Testless build
FRR › TOPOPR › #343 4 months ago
bgpd: fix wrong allocation size in rpki route map
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: use correct bgp tables for rpki revalidation
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix deadlock in rpki code
In some situations rtrlib does not release the locks for its internal
data structures before calling a callback. This can lead to deadlocks
when a lot of routes must be revalidated because the sync socket buffer
will fill up and block the rtrlib thread. The bgpd main thread then
waits for rtrlibs internal locks to be released indefinitely.

This is fixed by using nonblocking sockets instead of blocking ones and
setting a flag to revalidate everything, if it would block.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
5 of 972 failed
FRR › TOPOPR › #342 4 months ago
bgpd: use correct bgp tables for rpki revalidation
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix wrong allocation size in rpki route map
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix deadlock in rpki code
In some situations rtrlib does not release the locks for its internal
data structures before calling a callback. This can lead to deadlocks
when a lot of routes must be revalidated because the sync socket buffer
will fill up and block the rtrlib thread. The bgpd main thread then
waits for rtrlibs internal locks to be released indefinitely.

This is fixed by using nonblocking sockets instead of blocking ones and
setting a flag to revalidate everything, if it would block.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
6 of 972 failed
FRR › TOPOPR › #339 4 months ago
bgpd: use correct bgp tables for rpki revalidation
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix deadlock in rpki code
In some situations rtrlib does not release the locks for its internal
data structures before calling a callback. This can lead to deadlocks
when a lot of routes must be revalidated because the sync socket buffer
will fill up and block the rtrlib thread. The bgpd main thread then
waits for rtrlibs internal locks to be released indefinitely.

This is fixed by using nonblocking sockets instead of blocking ones and
setting a flag to revalidate everything, if it would block.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix wrong allocation size in rpki route map
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
689 passed
FRR › TOPOPR › #338 4 months ago
bgpd: fix deadlock in rpki code
In some situations rtrlib does not release the locks for its internal
data structures before calling a callback. This can lead to deadlocks
when a lot of routes must be revalidated because the sync socket buffer
will fill up and block the rtrlib thread. The bgpd main thread then
waits for rtrlibs internal locks to be released indefinitely.

This is fixed by using nonblocking sockets instead of blocking ones and
setting a flag to revalidate everything, if it would block.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix wrong allocation size in rpki route map
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: use correct bgp tables for rpki revalidation
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
10 of 824 failed
FRR › TOPOPR › #337 4 months ago
bgpd: fix deadlock in rpki code
In some situations rtrlib does not release the locks for its internal
data structures before calling a callback. This can lead to deadlocks
when a lot of routes must be revalidated because the sync socket buffer
will fill up and block the rtrlib thread. The bgpd main thread then
waits for rtrlibs internal locks to be released indefinitely.

This is fixed by using nonblocking sockets instead of blocking ones and
setting a flag to revalidate everything, if it would block.

Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: use correct bgp tables for rpki revalidation
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: fix wrong allocation size in rpki route map
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
28 of 918 failed
RPKI › RTRLIB › #43 4 months ago
tools: fix install type for tools (#171)
According to the cmake documentation TARGETS is supposed to be used for
all files that where build by the project. PROGRAMS is for scripts and
such.
Testless build
FRR › TOPOPR › #278 5 months ago
bgpd: add test for bgp_table_range_lookup
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: add support for rpki revalidation on rpki updates
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
2 of 918 failed
FRR › TOPOPR › #277 5 months ago
bgpd: add test for bgp_table_range_lookup
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: add support for rpki revalidation on rpki updates
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
1 of 927 failed
FRR › TOPOPR › #276 5 months ago
bgpd: add support for rpki revalidation on rpki updates
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
bgpd: add test for bgp_table_range_lookup
Signed-off-by: Marcel Röthke <marcel.roethke@haw-hamburg.de>
31 of 918 failed
Build Completed Code commits Tests
RPKI › RTRLIB › #67 1 month ago
tests: add missing include in test_pfx (#209)
The compiler complained about an implicit function declaration because
of a missing include.
Testless build
RPKI › RTRLIB › #63 1 month ago
rtrlib: support use in c++ projects (#200)
To support inclusion from c++ projects the name mangling must be
disabled for rtrlib symbols, otherwise the linker can't find them.
Testless build
RPKI › RTRLIB › #60 1 month ago
cmake: fix library installation path (again) (#197)
GNUInstallDirs and UseMultiArch conflict with each other on newer deb
based distributions because both expand CMAKE_INSTALL_LIBDIR.
Testless build
RPKI › RTRLIB › #57 2 months ago
rtr_mgr: wrap tommy_list in rtr_mgr_config in a struct
The purpose of this is to hide tommy symbols from public headers without
forward declaring tommy_list. Which is only possible with C11 as it is
typedefed.
Testless build
You have insufficient permissions to see all of the builds.