Merge pull request #7923 from donaldsharp/gcc10-cleanups
Gcc10 cleanups

Merge pull request #7923 from donaldsharp/gcc10-cleanups
Gcc10 cleanups

libs,zebra: remove zapi nhg encode and decode public apis
The raw zapi apis to encode and decode NHGs don't need to be
public; also add a little more validity-checking.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

sharpd: don't send invalid nexthop-groups to zebra
Ensure that there are valid (resolved) nexthops, and no
invalid backup nexthops, in nhgs sent to zebra for
installation.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: use afi_t for route-map address family arg
Use afi_t in the route_map_check api

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: send async nhg update results
Send the results of daemons' nhg updates asynchronously,
after the update has actually completed. Capture additional
info about the source daemon in order to locate the correct
zapi session. Simplify the result types considered by the
zebra_nhg module.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

Merge pull request #7906 from donaldsharp/sig_abrt
lib: Allow us to catch abort and do some small cleanup

Merge pull request #7877 from vishaldhingra/static_7_5
[7.5] staticd: correct table-id handling for static routes

Merge pull request #7854 from patrasar/2606829
bgpd : multiple memory leak fixes in show commands

Merge pull request #7888 from donaldsharp/1_19_coverity
lib: Fix up str2prefix usage in lua code

Merge pull request #7875 from deastoe/fpm-nlmsg-pid
zebra: set nlmsg_pid in netlink msgs sent by 'fpm'

Merge pull request #7844 from vishaldhingra/static
staticd: correct table-id handling for static routes.

Merge pull request #7870 from donaldsharp/pytest_marking
tests: Start the ability to mark tests

Merge pull request #7866 from kishorekunal01/fpm_dump_issue
zebra: Scale setup RMAC is send multiple time to fpm

Merge pull request #7866 from kishorekunal01/fpm_dump_issue
zebra: Scale setup RMAC is send multiple time to fpm

Merge pull request #7866 from kishorekunal01/fpm_dump_issue
zebra: Scale setup RMAC is send multiple time to fpm

Merge pull request #7866 from kishorekunal01/fpm_dump_issue
zebra: Scale setup RMAC is send multiple time to fpm

Merge pull request #7821 from donaldsharp/evpn_flag_dump
Evpn flag dump

Merge pull request #7712 from dslicenc/frr-reload-prefix-list-acl
tools: ignore missing seq nums in prefix and access lists in frr-relo…

libs,zebra: remove zapi nhg encode and decode public apis
The raw zapi apis to encode and decode NHGs don't need to be
public; also add a little more validity-checking.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

sharpd: don't send invalid nexthop-groups to zebra
Ensure that there are valid (resolved) nexthops, and no
invalid backup nexthops, in nhgs sent to zebra for
installation.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: use afi_t for route-map address family arg
Use afi_t in the route_map_check api

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: send async nhg update results
Send the results of daemons' nhg updates asynchronously,
after the update has actually completed. Capture additional
info about the source daemon in order to locate the correct
zapi session. Simplify the result types considered by the
zebra_nhg module.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

Merge pull request #7233 from donaldsharp/route_map_optimizations
Route map optimizations

Merge pull request #7870 from donaldsharp/pytest_marking
tests: Start the ability to mark tests

zebra: don't set connection-up event pointer directly
Use thread_cancel to reset the connection-up processing timer.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: remove useless deleted route_entries promptly
Zebra accumulates route-entry objects and then processes them
as a group. If that rib processing is delayed, because the
dataplane/fib programming has built up a queue e.g., zebra can
hold multiple deleted route objects in memory. At scale, this can
be a problem. Delete unneeded route entries promptly, if they
can't contribute to rib processing.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

zebra: improve dataplane plugin queue counters
Add the current queue depths for each plugin to the
'show dplane providers' output. Maintain the out-bound queue
max counter properly, that was being ignored.

Signed-off-by: Mark Stapp <mjs@voltanet.io>

Merge pull request #7762 from sworleys/PBR-Ipv4/Ipv6-Match-Fixes
pbrd: pbr ipv4/ipv6 match fixes

Merge pull request #7758 from donaldsharp/tests_dict_values
tests: dict_values are not lists in version 3

Merge pull request #7690 from donaldsharp/nht_show_is_not_not_not
zebra, tests: Fix `show ip nht`

Merge pull request #7561 from donaldsharp/resources_are_the_life
lib: Stop socket from leaking.

tests: only test count of nexthops in bgp max-paths test
Add support to compare the number of RIB nexthops, rather than the
specific nexthop addresses. Use this in the bgp_ecmp topotests that
test maximum-paths - testing the specific nexthops is wrong there,
it's not deterministic and we get spurious failures.

Signed-off-by: Mark Stapp <mjs@voltanet.io>