Ruben Kerkhof <ruben@rubenkerkhof.com>: Author Summary

Builds triggered by Ruben Kerkhof <ruben@rubenkerkhof.com>

Builds triggered by an author are those builds which contains changes committed by the author.
26
16 (62%)
10 (38%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
7 (27% of all builds triggered)
0 (0% of all builds triggered)
-7
Build Completed Code commits Tests
FRR › FRR › #2026 1 month ago
doc: fix a couple of typos
Found with https://github.com/codespell-project/codespell

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
doc: address review comment
'cannot' feels more natural

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6996 passed
FRR › FRR › #2018 1 month ago
tools: fix two typos in daemons file
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6998 passed
FRR › FRR › #1875 3 months ago
Redirect output of $AR check to /dev/null
./configure logs this on Mac OS:

checking whether ar supports D option... /Library/Developer/CommandLineTools/usr/bin/ar: illegal option -- D
usage:  ar -d [-TLsv] archive file ...
        ar -m [-TLsv] archive file ...
        ar -m [-abiTLsv] position archive file ...
        ar -p [-TLsv] archive [file ...]
        ar -q [-cTLsv] archive file ...
        ar -r [-cuTLsv] archive file ...
        ar -r [-abciuTLsv] position archive file ...
        ar -t [-TLsv] archive [file ...]
        ar -x [-ouTLsv] archive [file ...]
no

This is quite noisy and we're only interested in the result of the
check, not the output.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Only check for .interp when we have objcopy
On Mac OS, where we don't have objcopy, ./configure logs:

checking for objcopy... no
checking for .interp value to use... ./configure: line 22174: conftest.interp: No such file or directory

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Fix compile error on Mac OS
  CC       lib/frr_pthread.lo
lib/frr_pthread.c:128:40: error: too many arguments to function call, expected 1, have 3
        ret = pthread_setname_np(fpt->thread, fpt->os_name, NULL);
              ~~~~~~~~~~~~~~~~~~              ^~~~~~~~~~~~~~~~~~
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/pthread.h:512:1: note: 'pthread_setname_np' declared here
__API_AVAILABLE(macos(10.6), ios(3.2))

Mac OS does have pthread_setname_np, but we can't use it here since it
only accepts a single argument, the thread name, and thus only works for
the current thread.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Fix 'make clean' os Mac OS
The find command on Mac OS needs a path as first argument, or else
it outputs:

find -name __pycache__ -o -name .pytest_cache | xargs rm -rf
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]
find -name "*.pyc" -o -name "*_clippy.c" | xargs rm -f
find: illegal option -- n
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
Redirect output of ranlib to /dev/null
./configure on Mac OS logs:
checking whether ranlib supports D option... error: /Library/Developer/CommandLineTools/usr/bin/ranlib: unknown option character `D' in: -D
Usage: /Library/Developer/CommandLineTools/usr/bin/ranlib [-sactfqLT] [-] archive [...]
no

This is quite noisy.

Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6996 passed
You have insufficient permissions to see all of the builds.
Build Completed Code commits Tests
FRR › TOPOPR › #385 6 months ago
configure.ac: fix a typo in an error message
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
configure.ac: consistently quote all m4 macros
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
4 of 1240 failed
FRR › TOPOPR › #384 6 months ago
configure.ac: fix a typo in an error message
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
configure.ac: consistently quote all m4 macros
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6 of 1240 failed
FRR › FRR › #1701 6 months ago
configure.ac: consistently quote all m4 macros
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6449 passed
FRR › TOPOPR › #383 6 months ago
configure.ac: fix a typo in an error message
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
5 of 1240 failed
FRR › TOPOPR › #382 6 months ago
configure.ac: fix a typo in an error message
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
6 of 1240 failed
FRR › FRR › #1674 6 months ago
configure.ac: fix a typo in an error message
Signed-off-by: Ruben Kerkhof <ruben@rubenkerkhof.com>
3 of 7016 failed
You have insufficient permissions to see all of the builds.
Build Completed Code commits Tests