paco <paco@voltanet.io>: Author Summary

Builds triggered by paco <paco@voltanet.io>

Builds triggered by an author are those builds which contains changes committed by the author.
119
36 (30%)
83 (70%)

Breakages and fixes

Broken means the build has failed but the previous build was successful.
Fixed means that the build was successful but the previous build has failed.
22 (18% of all builds triggered)
17 (14% of all builds triggered)
-5
Build Completed Code commits Tests
FRR › FRRPULLREQ › #6088 7 months ago
lib, lm-proxy-topo1: label manager proxy test
Label proxy manager test covering both LDP and BGP label requests.

lib/topotest.py:restartRouter() function has been fixed in order to
allow propagating options to deamons other than zebra.

Signed-off-by: F. Aragon <paco@voltanet.io>
5934 passed
FRR › FRR › #1732 7 months ago
lib, lm-proxy-topo1: label manager proxy test
Label proxy manager test covering both LDP and BGP label requests.

lib/topotest.py:restartRouter() function has been fixed in order to
allow propagating options to deamons other than zebra.

Signed-off-by: F. Aragon <paco@voltanet.io>
6046 passed
FRR › TOPOPR › #385 7 months ago
lib, lm-proxy-topo1: label manager proxy test
Label proxy manager test covering both LDP and BGP label requests.

lib/topotest.py:restartRouter() function has been fixed in order to
allow propagating options to deamons other than zebra.

Signed-off-by: F. Aragon <paco@voltanet.io>
4 of 1240 failed
FRR › FRR › #1554 9 months ago
bgpd, doc, ldpd, lib, tests, zebra: LM fixes
Corrections so that the BGP daemon can work with the label manager properly
through a label-manager proxy. Details:

- Correction so the BGP daemon behind a proxy label manager gets the range
  correctly (-I added to the BGP daemon, to set the daemon instance id)
- For the BGP case, added an asynchronous label manager connect command so
  the labels get recycled in case of a BGP daemon reconnection. With this,
  BGPd and LDPd would behave similarly.

Signed-off-by: F. Aragon <paco@voltanet.io>
7309 passed
FRR › TOPOPR › #255 1 year ago
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
734 passed
FRR › TOPOPR › #254 1 year ago
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
lib zebra: str-z check (2) (Coverity 1465494)
This is an additional correction after  45981fda0634f7277c27c2a55e30d7f3433ffa16 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: untrusted argument (Coverity 1448386)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
664 passed
FRR › TOPOPR › #253 1 year ago
ospfd: dead code (Coverity 1302500)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: return check (Coverity 1465490)
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib zebra: str-z check (2) (Coverity 1465494)
This is an additional correction after  45981fda0634f7277c27c2a55e30d7f3433ffa16 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: untrusted argument (Coverity 1448386)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib ospfd: dead code (Coverity 1302503 1302502)
Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: untrusted argument (3) (Coverity 1465491)
Additional fix over d94023d85c1682ae14def9d50f2474e8e6290e44 (PR #2546)

Removed all pointer arithmetic used for the checks, while keeping same
coverage. I hope this removes the Coverity warning (If this don't fix it, I'll
make Coverity work with a fork and try there as many times as necessary)

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
667 passed
FRR › TOPOPR › #252 1 year ago
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: dead code (Coverity 1302500)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: return check (Coverity 1465490)
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
lib: untrusted argument (Coverity 1448386)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib zebra: str-z check (2) (Coverity 1465494)
This is an additional correction after  45981fda0634f7277c27c2a55e30d7f3433ffa16 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib ospfd: dead code (Coverity 1302503 1302502)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: untrusted argument (3) (Coverity 1465491)
Additional fix over d94023d85c1682ae14def9d50f2474e8e6290e44 (PR #2546)

Removed all pointer arithmetic used for the checks, while keeping same
coverage. I hope this removes the Coverity warning (If this don't fix it, I'll
make Coverity work with a fork and try there as many times as necessary)

Signed-off-by: F. Aragon <paco@voltanet.io>
11 of 776 failed
You have insufficient permissions to see all of the builds.
Build Completed Code commits Tests
FRR › TOPOPR › #385 7 months ago
lib, lm-proxy-topo1: label manager proxy test
Label proxy manager test covering both LDP and BGP label requests.

lib/topotest.py:restartRouter() function has been fixed in order to
allow propagating options to deamons other than zebra.

Signed-off-by: F. Aragon <paco@voltanet.io>
4 of 1240 failed
FRR › TOPOPR › #252 1 year ago
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: dead code (Coverity 1302500)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: return check (Coverity 1465490)
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
lib: untrusted argument (Coverity 1448386)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib zebra: str-z check (2) (Coverity 1465494)
This is an additional correction after  45981fda0634f7277c27c2a55e30d7f3433ffa16 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib ospfd: dead code (Coverity 1302503 1302502)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: untrusted argument (3) (Coverity 1465491)
Additional fix over d94023d85c1682ae14def9d50f2474e8e6290e44 (PR #2546)

Removed all pointer arithmetic used for the checks, while keeping same
coverage. I hope this removes the Coverity warning (If this don't fix it, I'll
make Coverity work with a fork and try there as many times as necessary)

Signed-off-by: F. Aragon <paco@voltanet.io>
11 of 776 failed
FRR › TOPOPR › #251 1 year ago
pimd: untrusted argument (3) (Coverity 1465491)
Additional fix over d94023d85c1682ae14def9d50f2474e8e6290e44 (PR #2546)

Removed all pointer arithmetic used for the checks, while keeping same
coverage. I hope this removes the Coverity warning (If this don't fix it, I'll
make Coverity work with a fork and try there as many times as necessary)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib: untrusted argument (Coverity 1448386)
Signed-off-by: F. Aragon <paco@voltanet.io>
pimd: return check (Coverity 1465490)
Unless someone intentionally changes MCAST_ALL_ROUTERS ("224.0.0.2") with a
wrong IP, this should never fail, so the fix is using "(void)" at the left
of the function call, as an explicit way of indicating we discard the
return value on purpose.

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: copy-paste error (Coverity 1399202)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: dead code (Coverity 1399228)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib zebra: str-z check (2) (Coverity 1465494)
This is an additional correction after  45981fda0634f7277c27c2a55e30d7f3433ffa16 / PR #2462. I hope
this fixes the Coverity warning (I've added an additional check for ensuring
the string provided by the inotify read is zero-terminated).

Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: dead code (Coverity 1399231)
It should have the same behavior when debug not enabled, and slightly
different behavior when debug enabled (previously dead code now should
show debug messages in debug mode)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 23065)
Signed-off-by: F. Aragon <paco@voltanet.io>
lib ospfd: dead code (Coverity 1302503 1302502)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospfd: dead code (Coverity 1302500)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: return value (Coverity 1399203)
The return value can be ignored because in case of error both the 'afi'
and 'safi' variables are set to the invalid values (AFI_MAX, SAFI_MAX),
and the invalid values are handled properly afterwards in the 'default'
blocks.

Signed-off-by: F. Aragon <paco@voltanet.io>
52 of 776 failed
FRR › FRR › #1282 1 year ago
bgpd: copy-paste error (Coverity 1399219)
Signed-off-by: F. Aragon <paco@voltanet.io>
6732 passed
FRR › FRR › #1274 1 year ago
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
ospf6d: null check (Coverity 23024)
Signed-off-by: F. Aragon <paco@voltanet.io>
2 of 7591 failed
FRR › FRR › #1263 1 year ago
ldpd: null check (Coverity 1452317)
Signed-off-by: F. Aragon <paco@voltanet.io>
7482 passed
FRR › FRR › #1258 1 year ago
lib: null check (Coverity 1470150)
Signed-off-by: F. Aragon <paco@voltanet.io>
6732 passed
FRR › FRR › #1251 1 year ago
ldpd lib: null check (Coverity 1452287 + 20 alike)
Coverity issues fixed with this commit:

1452287 1452291 1452307 1452310 1452317 1452321 1452327 1452330 1452331 1452336
1452337 1452340 1452352 1452354 1452358
(originated at ldpd/ldpd_vty_cmds_clippy.c)

1448388 1448390 1448392 1448397 1448404 1448408
(originated at lib/plist_clippy.c)

Signed-off-by: F. Aragon <paco@voltanet.io>
tools: return check (2) (Coverity 1143220)
Previous correction (657f9948ed593387d29d391832c18dc04326a5a9) was incomplete.

Signed-off-by: F. Aragon <paco@voltanet.io>
2 of 7591 failed
FRR › FRR › #1248 1 year ago
eigrpd: null check (Coverity 1455334 and 4 alike)
Coverity issues fixed with this commit:

1455334 1455335 1455336 1455337 1455339

Signed-off-by: F. Aragon <paco@voltanet.io>
6732 passed
FRR › FRR › #1242 1 year ago
zebra: untrusted array index (Coverity 1470113)
This is a correction over 32ac96b2ba9693696d2f1156af1b80985d4e55bb, so
removing the forced string null termination doesn't involve a worse situation
than before (the underflow check should protect for the case of receiving
an incomplete buffer, which would be the cause of non-zero terminated string)

Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd ospf6d: null check (Coverity 1221453 1461297)
6732 passed
Build Completed Code commits Tests
FRR › FRR › #1554 9 months ago
bgpd, doc, ldpd, lib, tests, zebra: LM fixes
Corrections so that the BGP daemon can work with the label manager properly
through a label-manager proxy. Details:

- Correction so the BGP daemon behind a proxy label manager gets the range
  correctly (-I added to the BGP daemon, to set the daemon instance id)
- For the BGP case, added an asynchronous label manager connect command so
  the labels get recycled in case of a BGP daemon reconnection. With this,
  BGPd and LDPd would behave similarly.

Signed-off-by: F. Aragon <paco@voltanet.io>
7309 passed
FRR › FRR › #1283 1 year ago
ospf6d: OoB read (Coverity 1221444 1221446)
Signed-off-by: F. Aragon <paco@voltanet.io>
7510 passed
FRR › FRR › #1275 1 year ago
lib: null check (2) (Coverity 1451361)
Additional correction to fa3016309b33395c02cf10e7e198517c5b81e55a

Signed-off-by: F. Aragon <paco@voltanet.io>
7513 passed
FRR › FRR › #1266 1 year ago
isisd: out-of-bounds access (Coverity 1452552)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: null check (Coverity 1468413)
Signed-off-by: F. Aragon <paco@voltanet.io>
7510 passed
FRR › FRR › #1259 1 year ago
ripd: out-of-bounds read (Coverity 1399295)
Signed-off-by: F. Aragon <paco@voltanet.io>
7507 passed
FRR › FRR › #1252 1 year ago
bgpd isisd ldpd lib ospfd pimd: redundancy (infer)
Signed-off-by: F. Aragon <paco@voltanet.io>
7513 passed
FRR › FRR › #1249 1 year ago
spf6d: fix use after free (2) (Coverity 1221459)
Previous fix was incomplete, as calling ospf6_lsa_unlock() frees 'req' but
it does not put it to zero, so it was called ospf6_lsdb_remove() afterwards
even being 'req' already freed.

Signed-off-by: F. Aragon <paco@voltanet.io>
7510 passed
FRR › FRR › #1243 1 year ago
ospfd: null check (Coverity 23110)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd, lib: null check (Coverity 1436344, 1451361)
Signed-off-by: F. Aragon <paco@voltanet.io>
7510 passed
FRR › FRR › #1237 1 year ago
bgpd: Untrusted argument (Coverity 1399380)
Signed-off-by: F. Aragon <paco@voltanet.io>
7510 passed
FRR › FRR › #1223 1 year ago
bgpd: null check (Clang scan-build)
Signed-off-by: F. Aragon <paco@voltanet.io>
bgpd: vpn null check
Can be reproduced with following vtysh sequence (an intentionaly wrong
sequence):

['configure terminal\n router bgp 255 vrf l3vrf-6\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\nbgp router-id 10.255.255.1\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nlabel vpn export 45000\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrd vpn export 255:5\n',
 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute isis\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute ospf\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nredistribute connected\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nimport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nexport vpn\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn import 255:1\n', 'configure terminal\n router bgp 255 vrf l3vrf-6\n address-family ipv4\nrt vpn export 255:1\n'
]

Signed-off-by: F. Aragon <paco@voltanet.io>
7006 passed