Build #1,722

FreeRangeRouting Protocol Suite

Build: #1722 failed Changes by Russ White <russ@riw.us>

Build result summary

Details

Completed
Duration
116 minutes
Labels
branch=masterbuildurl=https_//ci1_netdef_org/browse/frr-frr-1722version=frr-6_1-dev-876-geda41b4c2git=https_//github_com/frrouting/frr_git
Revision
eda41b4c212f283484840c4e0bf5c611b192d4c6 eda41b4c212f283484840c4e0bf5c611b192d4c6
Total tests
7016
Fixed in
#1723 (Changes by Russ White <russ@riw.us>)

Tests

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Russ White <russ@riw.us> Russ White <russ@riw.us> eda41b4c212f283484840c4e0bf5c611b192d4c6 eda41b4c212f283484840c4e0bf5c611b192d4c6 Merge pull request #3325 from adeg/bugfix/bgpd-vtysh-fixes
bgp_vty: Fix vpn_leak_postchange_all() every time "router bgp ASNUM" context is entered
Anton Degtyarev <adeg47@gmail.com> Anton Degtyarev <adeg47@gmail.com> 3702f84d9f86e9c091037c984e349823884a7d93 m 3702f84d9f86e9c091037c984e349823884a7d93 bgpd: add missing endline
Missing endline was resulting in garbled output in vtysh in some cases, for example, when there were no peers configured and the user has issued "bgp disable-ebgp-connected-route-check" command.

Signed-off-by: Anton Degtyarev <anton@cumulusnetworks.com>
Anton Degtyarev <adeg47@gmail.com> Anton Degtyarev <adeg47@gmail.com> ecec94950f3a959fad5d8e418a21d0bbfc9b4ce8 m ecec94950f3a959fad5d8e418a21d0bbfc9b4ce8 bgpd: Fix bgpd doing vpn_leak_postchange_all() every time "router bgp ASNUM" command is entered in vtysh
In rare cases when the default BGP instance is instantiated after VRF bgp instances (see comment to bgp_mplsvpn.c:vpn_leak_postchange_all() for an example), the "router bgp" command needs to call vpn_leak_postchange_all() to start the route leaking process. The issue was it was never checked if the "router bgp" command was used to create the default BGP instance or just to enter into "router bgp" command context. This resulted in vpn_leak_postchange_all() executed every time (and vpn routes re-announced to all peers) when the user was entering "router bgp" command context.

Signed-off-by: Anton Degtyarev <anton@cumulusnetworks.com>

Tests

New test failures 3
Status Test View job Duration
Collapse Failed test_bfd_topo1 test_bgp_fast_reconvergence History
Topology Tests on Ubuntu 16.04 arm8 6 secs
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +1,0 @@   -    "10.254.254.1/32": null,    @@ -5,0 +5,4 @@   +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -12,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -16 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -19 +26 @@   -    "10.254.254.3/32": [   +    "10.254.254.4/32": [   @@ -21 +28,5 @@   -            "aspath": "102 103",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -25 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -29,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -32 +46,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +1,0 @@
      -    "10.254.254.1/32": null, 
      @@ -5,0 +5,4 @@
(37 more lines...)
Collapse Failed test_bfd_topo1 test_bgp_fast_convergence History
Topology Tests on Ubuntu 16.04 arm8 40 secs
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32', u'10.254.254.1/32']):   --- Expected value   +++ Current value   @@ -4,0 +5,2 @@   +            "bestpath": true,    +            "network": "10.254.254.1/32",    @@ -11,0 +14,3 @@   +            "origin": "IGP",    +            "path": "102 101",    +            "pathFrom": "external",    @@ -15 +20,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -20,0 +27,4 @@   +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -27,0 +38,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -31 +44,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -34 +48 @@   -    "10.254.254.3/32": [   +    "10.254.254.4/32": [   @@ -36 +50,5 @@   -            "aspath": "102 103",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -40 +58 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -44,2 +62,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -47 +68,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32', u'10.254.254.1/32']):
      --- Expected value
      +++ Current value
      @@ -4,0 +5,2 @@
      +            "bestpath": true, 
      +            "network": "10.254.254.1/32", 
(46 more lines...)
Collapse Failed test_bfd_topo1 test_bgp_convergence History
Topology Tests on Ubuntu 16.04 arm8 22 secs
AssertionError: r2: bgp did not converge assert json["ipv4Unicast"]["peers"]["192.168.1.1"]["state"] value is different (   --- Expected value   +++ Current value   @@ -1 +1 @@   -"Established"   +"Active")
E   AssertionError: r2: bgp did not converge
    assert json["ipv4Unicast"]["peers"]["192.168.1.1"]["state"] value is different (
      --- Expected value
      +++ Current value
      @@ -1 +1 @@
      -"Established"
      +"Active")