Build #1,758

FreeRangeRouting Protocol Suite

Build: #1758 failed Changes by Donald Sharp

Build result summary

Details

Completed
Duration
116 minutes
Labels
version=frr-6_1-dev-1395-g8ba26ecdagit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-1758branch=master
Revision
8ba26ecda7ccc1e1ea93cbe66efb4c9fcd962ecb 8ba26ecda7ccc1e1ea93cbe66efb4c9fcd962ecb
Total tests
7156
Failing since
#1739 (Changes by Donald Sharp)
Fixed in
#1774 (Changes by Donald Sharp and David Lamparter)

Responsible

This build has been failing since #1739
No one has taken responsibility

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 8ba26ecda7ccc1e1ea93cbe66efb4c9fcd962ecb 8ba26ecda7ccc1e1ea93cbe66efb4c9fcd962ecb Merge pull request #3419 from opensourcerouting/freebsd-route-warning-fix
zebra: fix some boot up warnings on FreeBSD
Rafael Zalamena Rafael Zalamena c69f2c1fffbae8d0bd5b69c627c4217d6ce97aed m c69f2c1fffbae8d0bd5b69c627c4217d6ce97aed zebra: don't log errors on unsupported medias
When using `SIOCGIFMEDIA` check for `EINVAL`, otherwise we might print
an error message on an unsupported interface.

FreeBSD source code reference:
https://github.com/freebsd/freebsd/blob/master/sys/net/if_media.c#L300

And:
https://github.com/freebsd/freebsd/blob/8cb4b0c0181bd45318ee8977f77aea90c53bb224/usr.sbin/rtsold/if.c#L211

  /*
   * EINVAL simply means that the interface does not support
   * the SIOCGIFMEDIA ioctl. We regard it alive.
   */

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena Rafael Zalamena 86c57af534173d417189404ae005a610d84ee155 m 86c57af534173d417189404ae005a610d84ee155 zebra: refactor route socket message handling
Some address types were not being skipped triggering a warning log
message, so lets refactor this code to properly handle known and unknown
types.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena Rafael Zalamena cb800e3529aa19d36565acda41c79cb0b19a1d3b m cb800e3529aa19d36565acda41c79cb0b19a1d3b zebra: always define ROUNDUP and ROUND_TYPE
Move the declaration of ROUNDUP and ROUND_TYPE to outside of
`ifdef SA_SIZE`. We'll use these definitions in the next commit.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Configuration changes

Plan configuration has changed since the last successful build. See the plan audit log for more details.

Tests

Existing test failures 7
Status Test Failing since View job Duration
AssertionError: 3 tests failed
E   AssertionError: 3 tests failed
AssertionError: 3 tests failed
E   AssertionError: 3 tests failed
AssertionError: IPv4 Zebra Routing Table verification failed for router r2:   --- actual IPv4 zebra routing table   +++ expected IPv4 zebra routing table   @@ -1,6 +1,6 @@    O>* 1.1.1.1/32 [110/10] via 10.0.1.1, r2-eth0, label implicit-null    O   2.2.2.2/32 [110/0] is directly connected, lo   -O>  3.3.3.3/32 [110/10] via 10.0.2.3, r2-eth1   +O>* 3.3.3.3/32 [110/10] via 10.0.2.3, r2-eth1, label implicit-null    O>* 4.4.4.4/32 [110/10] via 10.0.2.4, r2-eth1, label implicit-null    O   10.0.1.0/24 [110/10] is directly connected, r2-eth0    O   10.0.2.0/24 [110/10] is directly connected, r2-eth1 assert 1 == 0
E   AssertionError: IPv4 Zebra Routing Table verification failed for router r2:
      --- actual IPv4 zebra routing table
      +++ expected IPv4 zebra routing table
      @@ -1,6 +1,6 @@
       O>* 1.1.1.1/32 [110/10] via 10.0.1.1, r2-eth0, label implicit-null
       O   2.2.2.2/32 [110/0] is directly connected, lo
      -O>  3.3.3.3/32 [110/10] via 10.0.2.3, r2-eth1
(5 more lines...)
AssertionError: MPLS table output for router r2:   --- actual MPLS table output   +++ expected MPLS table output   @@ -2,5 +2,6 @@       Label     Type          Nexthop     Label    --------  -------  ---------------  --------          XX      LDP         10.0.1.1  implicit-null   +      XX      LDP         10.0.2.3  implicit-null          XX      LDP         10.0.2.4  implicit-null          XX      LDP         10.0.3.3  implicit-null assert 1 == 0
E   AssertionError: MPLS table output for router r2:
      --- actual MPLS table output
      +++ expected MPLS table output
      @@ -2,5 +2,6 @@
          Label     Type          Nexthop     Label
       --------  -------  ---------------  --------
             XX      LDP         10.0.1.1  implicit-null
(4 more lines...)
AssertionError: Linux Kernel MPLS route output for router r2:   --- actual Linux Kernel MPLS route   +++ expected Linux Kernel MPLS route   @@ -1,3 +1,3 @@   +xx proto xx nexthopvia inet 10.0.2.3 dev r2-eth1 nexthopvia inet 10.0.3.3 dev r2-eth2    xx via inet 10.0.1.1 dev r2-eth0 proto xx    xx via inet 10.0.2.4 dev r2-eth1 proto xx   -xx via inet 10.0.3.3 dev r2-eth2 proto xx assert 1 == 0
E   AssertionError: Linux Kernel MPLS route output for router r2:
      --- actual Linux Kernel MPLS route
      +++ expected Linux Kernel MPLS route
      @@ -1,3 +1,3 @@
      +xx proto xx nexthopvia inet 10.0.2.3 dev r2-eth1 nexthopvia inet 10.0.3.3 dev r2-eth2
       xx via inet 10.0.1.1 dev r2-eth0 proto xx
       xx via inet 10.0.2.4 dev r2-eth1 proto xx
(2 more lines...)
AssertionError: MPLS LDP Interface binding output for router r4:   --- actual MPLS LDP binding output   +++ expected MPLS LDP binding output   @@ -12,4 +12,4 @@    ipv4 10.0.2.0/24          2.2.2.2         imp-null    imp-null          no    ipv4 10.0.2.0/24          3.3.3.3         imp-null    imp-null          no    ipv4 10.0.3.0/24          2.2.2.2         xxx         imp-null         yes   -ipv4 10.0.3.0/24          3.3.3.3         xxx         imp-null          no   +ipv4 10.0.3.0/24          3.3.3.3         xxx         imp-null         yes assert 1 == 0
E   AssertionError: MPLS LDP Interface binding output for router r4:
      --- actual MPLS LDP binding output
      +++ expected MPLS LDP binding output
      @@ -12,4 +12,4 @@
       ipv4 10.0.2.0/24          2.2.2.2         imp-null    imp-null          no
       ipv4 10.0.2.0/24          3.3.3.3         imp-null    imp-null          no
       ipv4 10.0.3.0/24          2.2.2.2         xxx         imp-null         yes
(3 more lines...)
AssertionError: "r1" JSON output mismatches the expected result assert json value is different (   --- Expected value   +++ Current value   @@ -3,0 +4,2 @@   +        "internalFlags": 16,    +        "internalStatus": 2,    @@ -9 +11 @@   -                "fib": true,    +                "flags": 1,    @@ -17 +19 @@   -                "fib": true,    +                "flags": 1,    @@ -25 +27,2 @@   -        "selected": true   +        "selected": true,    +        "uptime": "00:03:44")
E   AssertionError: "r1" JSON output mismatches the expected result
    assert json value is different (
      --- Expected value
      +++ Current value
      @@ -3,0 +4,2 @@
      +        "internalFlags": 16, 
      +        "internalStatus": 2, 
(10 more lines...)
Fixed tests 3
Status Test Failing since View job Duration
Successful test_bfd_topo1 test_bgp_fast_convergence History
Failing since build #1757 (Manual run by Martin Winter) Topology Tests on Ubuntu 16.04 arm7 6 secs
Successful test_bfd_topo1 test_bgp_convergence History
Failing since build #1757 (Manual run by Martin Winter) Topology Tests on Ubuntu 16.04 arm7 6 secs
Successful test_bgp_l3vpn_to_bgp_direct test_adjacencies History
Failing since build #1756 (Changes by Lou Berger and Philippe Guibert) Topology Tests on Ubuntu 16.04 arm7 1 min