Build #1,997

FreeRangeRouting Protocol Suite

Build: #1997 failed Rebuilt by Martin Winter

Build result summary

Details

Completed
Duration
138 minutes
Labels
version=frr-7_1-dev-508-g29d894affgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-1997branch=master
Revision
29d894affc5318a920685fe34650e8fedcd852eb 29d894affc5318a920685fe34650e8fedcd852eb
Total tests
6635
Fixed in
#2012 (Changes by Quentin Young)
Number of retries
1

Tests

Responsible

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 29d894affc5318a920685fe34650e8fedcd852eb 29d894affc5318a920685fe34650e8fedcd852eb Merge pull request #3918 from opensourcerouting/bfd-bug-fixes
bfdd: bug fixes
Rafael Zalamena Rafael Zalamena 812f5a3d3b42617326ab62ae95b5a9c283da2e7f m 812f5a3d3b42617326ab62ae95b5a9c283da2e7f topotests: add new bfd topology with IPv6
New BFD topology using IPv6 and multi hop peer to cover more daemon
features. This topology also tests BFD integration with BGP, OSPF and
OSPF6.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena Rafael Zalamena 261e0ba94d24cc28462a12eda23d9ed8ce747765 m 261e0ba94d24cc28462a12eda23d9ed8ce747765 bfdd: don't enable sessions without local-address
When the local-address configured by the peer doesn't exist, then we
must observe the session until the mentioned address comes up.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena Rafael Zalamena 79b4a6fcebd7cca550c9661f54f48f74df12e5ea m 79b4a6fcebd7cca550c9661f54f48f74df12e5ea bfdd: change session lookup data structure
Use simplier data structure key to avoid having to do complex and
error-prone key building (e.g. avoid expecting caller to know IPv6
scope id, interface index, vrf index etc...).

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena Rafael Zalamena 2435b7defe734ab42f8b30368ff842aa0a5b6c42 m 2435b7defe734ab42f8b30368ff842aa0a5b6c42 bfdd: fix single hop IPv6 configurations
Don't assume IPv6 will always be multi hop and handle the single hop
link-local address case.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

Tests

New test failures 3
Status Test View job Duration
Collapse Failed test_bfd_topo1 test_bgp_convergence History
Topology Tests on Ubuntu 16.04 arm8 3 mins
AssertionError: r1: bgp did not converge assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (   --- Expected value   +++ Current value   @@ -1 +1 @@   -"Established"   +"Idle")
E   AssertionError: r1: bgp did not converge
    assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (
      --- Expected value
      +++ Current value
      @@ -1 +1 @@
      -"Established"
      +"Idle")
Collapse Failed test_bfd_topo1 test_bgp_fast_convergence History
Topology Tests on Ubuntu 16.04 arm8 41 secs
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +2 @@   -    "10.254.254.1/32": [   +    "10.254.254.2/32": [   @@ -4 +4,5 @@   -            "aspath": "102 101",    +            "aspath": "102",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -11,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -13 +20 @@   -            "prefix": "10.254.254.1",    +            "prefix": "10.254.254.2",    @@ -15 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -18 +26 @@   -    "10.254.254.2/32": [   +    "10.254.254.4/32": [   @@ -20 +28,5 @@   -            "aspath": "102",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -24 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -28,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.2",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -31,17 +46,2 @@   -            "valid": true   -        }   -    ],    -    "10.254.254.3/32": [   -        {   -            "aspath": "102 103",    -            "nexthops": [   -                {   -                    "afi": "ipv4",    -                    "ip": "192.168.2.2",    -                    "used": true   -                }   -            ],    -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    -            "prefixLen": 32,    -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +2 @@
      -    "10.254.254.1/32": [
      +    "10.254.254.2/32": [
(59 more lines...)
Collapse Failed test_bfd_topo1 test_bgp_fast_reconvergence History
Topology Tests on Ubuntu 16.04 arm8 6 secs
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +1,0 @@   -    "10.254.254.1/32": null,    @@ -5,0 +5,4 @@   +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -12,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -16 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -19 +26 @@   -    "10.254.254.3/32": [   +    "10.254.254.4/32": [   @@ -21 +28,5 @@   -            "aspath": "102 103",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -25 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -29,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -32 +46,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +1,0 @@
      -    "10.254.254.1/32": null, 
      @@ -5,0 +5,4 @@
(37 more lines...)