Build #2,000

FreeRangeRouting Protocol Suite

Build: #2000 failed Changes by Donald Sharp

Build result summary

Details

Completed
Duration
139 minutes
Labels
version=frr-7_1-dev-517-g7bc2b18cbgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-2000branch=master
Revision
7bc2b18cb4a1bb027169269b13def3c2cf3d97fb 7bc2b18cb4a1bb027169269b13def3c2cf3d97fb
Total tests
6635
Failing since
#1997 (Rebuilt by Martin Winter)
Fixed in
#2012 (Changes by Quentin Young)

Responsible

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 7bc2b18cb4a1bb027169269b13def3c2cf3d97fb 7bc2b18cb4a1bb027169269b13def3c2cf3d97fb Merge pull request #3900 from opensourcerouting/ripd-fix-no-passive-iface
ripd: fix removal of configured passive interfaces
Donald Sharp Donald Sharp 6e65fa2b6d14f6fa160c0d97d53ba876f9dbf71f 6e65fa2b6d14f6fa160c0d97d53ba876f9dbf71f Merge pull request #3902 from opensourcerouting/fix-removal-np-containers
lib: fix removal of yang non-presence containers
Renato Westphal Renato Westphal 1912caa2caf14936379df830e028d1492a061988 m 1912caa2caf14936379df830e028d1492a061988 lib: fix removal of yang non-presence containers
Non-presence containers don't have "destroy" callbacks. So, once
a np-container is deleted, we need to call the "destroy" callbacks
of its child nodes instead.

This commit doesn't fix any real problem as of now since all
np-containers from the FRR YANG modules contain or one more mandatory
child nodes, so they can't be deleted (libyang will add missing
np-containers when validating data). Nevertheless, upcoming YANG
modules should benefit from this change.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Renato Westphal Renato Westphal cacbffafc9f2e133d3c76f081635f67ae504d124 m cacbffafc9f2e133d3c76f081635f67ae504d124 lib: simplify code that calculates configuration diffs
This is just a small refactoring to reduce code duplication. No
behavior changes intended.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Renato Westphal Renato Westphal 58e39d522b1d55cdd58ce5833298bf23aa27ce05 m 58e39d522b1d55cdd58ce5833298bf23aa27ce05 ripd: fix removal of configured passive interfaces
libyang-0.16-rc3 fixed a bug [1] in which data would be auto-deleted
when it shouldn't. The problem is that the "no passive-interface"
command was relying on that wrong behavior, so the command was
affected when the libyang bug was fixed. Adapt the command to do
the right thing in order to get rid of the problem (regardless of
the libyang version being used).

"passive-interface default" still has problems though, but that
will be addressed separetely in the future.

Fixes #3870.

[1] https://github.com/CESNET/libyang/commit/8af82206908

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

Tests

New test failures 1
Status Test View job Duration
Collapse Failed test_bfd_topo2 test_protocols_convergence History
Topology Tests on Ubuntu 16.04 arm8 2 mins
AssertionError: "r1" JSON output mismatches assert json value is different (   --- Expected value   +++ Current value   @@ -2,0 +3 @@   +        "destSelected": true,    @@ -4 +5 @@   -        "installed": true,    +        "failed": true,    @@ -6 +7 @@   -        "internalStatus": 34,    +        "internalStatus": 66,    @@ -12,2 +13 @@   -                "fib": true,    -                "flags": 3,    +                "flags": 1,    @@ -15 +15,2 @@   -                "interfaceName": "r1-eth0"   +                "interfaceName": "r1-eth0",    +                "ip": "fe80::7402:f4ff:fe8f:ca4"   @@ -20 +21,2 @@   -        "selected": true   +        "selected": true,    +        "uptime": "00:02:43")   json value is different (   --- Expected value   +++ Current value   @@ -2,0 +3 @@   +        "destSelected": true,    @@ -4 +5 @@   -        "installed": true,    +        "failed": true,    @@ -6 +7 @@   -        "internalStatus": 34,    +        "internalStatus": 66,    @@ -12,2 +13 @@   -                "fib": true,    -                "flags": 3,    +                "flags": 1,    @@ -15 +15,2 @@   -                "interfaceName": "r1-eth0"   +                "interfaceName": "r1-eth0",    +                "ip": "fe80::7402:f4ff:fe8f:ca4"   @@ -20 +21,2 @@   -        "selected": true   +        "selected": true,    +        "uptime": "00:02:43")
E   AssertionError: "r1" JSON output mismatches
    assert json value is different (
      --- Expected value
      +++ Current value
      @@ -2,0 +3 @@
      +        "destSelected": true, 
      @@ -4 +5 @@
(40 more lines...)
Existing test failures 3
Status Test Failing since View job Duration
AssertionError: r1: bgp did not converge assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (   --- Expected value   +++ Current value   @@ -1 +1 @@   -"Established"   +"Idle")
E   AssertionError: r1: bgp did not converge
    assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (
      --- Expected value
      +++ Current value
      @@ -1 +1 @@
      -"Established"
      +"Idle")
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +2 @@   -    "10.254.254.1/32": [   +    "10.254.254.2/32": [   @@ -4 +4,5 @@   -            "aspath": "102 101",    +            "aspath": "102",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -11,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -13 +20 @@   -            "prefix": "10.254.254.1",    +            "prefix": "10.254.254.2",    @@ -15 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -18 +26 @@   -    "10.254.254.2/32": [   +    "10.254.254.4/32": [   @@ -20 +28,5 @@   -            "aspath": "102",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -24 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -28,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.2",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -31,17 +46,2 @@   -            "valid": true   -        }   -    ],    -    "10.254.254.3/32": [   -        {   -            "aspath": "102 103",    -            "nexthops": [   -                {   -                    "afi": "ipv4",    -                    "ip": "192.168.2.2",    -                    "used": true   -                }   -            ],    -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    -            "prefixLen": 32,    -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +2 @@
      -    "10.254.254.1/32": [
      +    "10.254.254.2/32": [
(59 more lines...)
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +1,0 @@   -    "10.254.254.1/32": null,    @@ -5,0 +5,4 @@   +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -12,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -16 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -19 +26 @@   -    "10.254.254.3/32": [   +    "10.254.254.4/32": [   @@ -21 +28,5 @@   -            "aspath": "102 103",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -25 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -29,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -32 +46,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +1,0 @@
      -    "10.254.254.1/32": null, 
      @@ -5,0 +5,4 @@
(37 more lines...)