Build #2,001

FreeRangeRouting Protocol Suite

Build: #2001 failed Changes by Donald Sharp

Build result summary

Details

Completed
Duration
180 minutes
Labels
version=frr-7_1-dev-519-g86dd09667git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-2001branch=master
Revision
86dd09667aad80fbd7f3e8d878f1733ebeda4f20 86dd09667aad80fbd7f3e8d878f1733ebeda4f20
Total tests
6635
Failing since
#1997 (Rebuilt by Martin Winter)
Fixed in
#2012 (Changes by Quentin Young)

Responsible

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 86dd09667aad80fbd7f3e8d878f1733ebeda4f20 86dd09667aad80fbd7f3e8d878f1733ebeda4f20 Merge pull request #3920 from AkhileshSamineni/show_bgp_ipv6_summary_fix_master
bgpd: Incorrect number of peers count in "show bgp ipv6 summary" output
Akhilesh Samineni <akhilesh.samineni@broadcom.com> Akhilesh Samineni <akhilesh.samineni@broadcom.com> 210ec2a0d63263be7178d494e044d6e570cd2f16 m 210ec2a0d63263be7178d494e044d6e570cd2f16 bgpd: Incorrect number of peers count in "show bgp ipv6 summary output
The "show bgp ipv6 summary" output displays incorrect number of peers count.

sonic# show bgp ipv6 summary

IPv6 Unicast Summary:
BGP router identifier 10.1.0.1, local AS number 65100 vrf-id 0
BGP table version 0
RIB entries 0, using 0 bytes of memory
Peers 5, using 103 KiB of memory
Peer groups 1, using 64 bytes of memory

Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd
2003::1 4 65099 0 0 0 0 0 never Active
2088::1 4 65100 0 0 0 0 0 never Active
3021::2 4 65100 0 0 0 0 0 never Active

Total number of neighbors 3
sonic#
In the above output, the peers count displays as 5 but the actual peer count is 3, i.e.. 3 neighbors are activated in ipv6 unicast address family.
Displayed peer count (5) is the number of the neighbors activated in a BGP instance.

Fix : Now the peers count displays the number of neighbors activated per afi/safi.
After Fix:
sonic# show bgp ipv6 summary

IPv6 Unicast Summary:
BGP router identifier 10.1.0.1, local AS number 65100 vrf-id 0
BGP table version 0
RIB entries 0, using 0 bytes of memory
Peers 3, using 62 KiB of memory
Peer groups 1, using 64 bytes of memory

Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd
2003::1 4 65099 0 0 0 0 0 never Active
2088::1 4 65100 0 0 0 0 0 never Active
3021::2 4 65100 0 0 0 0 0 never Active

Total number of neighbors 3
sonic#

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>

Tests

Existing test failures 3
Status Test Failing since View job Duration
AssertionError: r1: bgp did not converge assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (   --- Expected value   +++ Current value   @@ -1 +1 @@   -"Established"   +"Idle")
E   AssertionError: r1: bgp did not converge
    assert json["ipv4Unicast"]["peers"]["192.168.0.2"]["state"] value is different (
      --- Expected value
      +++ Current value
      @@ -1 +1 @@
      -"Established"
      +"Idle")
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +2 @@   -    "10.254.254.1/32": [   +    "10.254.254.2/32": [   @@ -4 +4,5 @@   -            "aspath": "102 101",    +            "aspath": "102",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -11,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -13 +20 @@   -            "prefix": "10.254.254.1",    +            "prefix": "10.254.254.2",    @@ -15 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -18 +26 @@   -    "10.254.254.2/32": [   +    "10.254.254.4/32": [   @@ -20 +28,5 @@   -            "aspath": "102",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -24 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -28,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.2",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -31,17 +46,2 @@   -            "valid": true   -        }   -    ],    -    "10.254.254.3/32": [   -        {   -            "aspath": "102 103",    -            "nexthops": [   -                {   -                    "afi": "ipv4",    -                    "ip": "192.168.2.2",    -                    "used": true   -                }   -            ],    -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    -            "prefixLen": 32,    -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32', u'10.254.254.1/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +2 @@
      -    "10.254.254.1/32": [
      +    "10.254.254.2/32": [
(59 more lines...)
AssertionError: r4: bgp did not converge assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):   --- Expected value   +++ Current value   @@ -2 +1,0 @@   -    "10.254.254.1/32": null,    @@ -5,0 +5,4 @@   +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.2/32",    @@ -12,0 +16,3 @@   +            "origin": "IGP",    +            "path": "102",    +            "pathFrom": "external",    @@ -16 +22,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 0   @@ -19 +26 @@   -    "10.254.254.3/32": [   +    "10.254.254.4/32": [   @@ -21 +28,5 @@   -            "aspath": "102 103",    +            "aspath": "",    +            "bestpath": true,    +            "med": 0,    +            "metric": 0,    +            "network": "10.254.254.4/32",    @@ -25 +36 @@   -                    "ip": "192.168.2.2",    +                    "ip": "0.0.0.0",    @@ -29,2 +40,5 @@   -            "peerId": "192.168.2.2",    -            "prefix": "10.254.254.3",    +            "origin": "IGP",    +            "path": "",    +            "pathFrom": "external",    +            "peerId": "(unspec)",    +            "prefix": "10.254.254.4",    @@ -32 +46,2 @@   -            "valid": true   +            "valid": true,    +            "weight": 32768
E   AssertionError: r4: bgp did not converge
    assert expected key(s) [u'10.254.254.3/32'] in json["routes"] (have [u'10.254.254.4/32', u'10.254.254.2/32']):
      --- Expected value
      +++ Current value
      @@ -2 +1,0 @@
      -    "10.254.254.1/32": null, 
      @@ -5,0 +5,4 @@
(37 more lines...)
Fixed tests 1
Status Test Failing since View job Duration
Successful test_bfd_topo2 test_protocols_convergence History
Failing since build #2000 (Changes by Donald Sharp) Topology Tests on Ubuntu 16.04 arm8 1 min