Build #2,104

FreeRangeRouting Protocol Suite

Build: #2104 was successful Changes by Donald Sharp

Build result summary

Details

Completed
Duration
126 minutes
Labels
version=frr-7_1-dev-872-ge158a90fcgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-2104branch=master
Revision
e158a90fc1da4c536deb1129141042917c305453 e158a90fc1da4c536deb1129141042917c305453
Total tests
6651
Successful since
#2102 ()

Tests

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp e158a90fc1da4c536deb1129141042917c305453 e158a90fc1da4c536deb1129141042917c305453 Merge pull request #4151 from opensourcerouting/ospf-assorted-20190417
assorted OSPF fixes
David Lamparter David Lamparter 33546baaad16b9ec53d1944a41e5a7f959b0408c m 33546baaad16b9ec53d1944a41e5a7f959b0408c ospfd: make ECMP nexthop order deterministic
The order of ECMP nexthops currently depends on whatever order the
pqueue code returns the vertices in, which is essentially random since
they compare as equal.  While this shouldn't cause issues normally, it
is nondeterministic and causes the ldp-topo1 test to fail when the
ordering comes up different.  Also, nondeterministic behaviour is not a
nice thing to have here in general.

Just sort by nexthop address;  realistic numbers of ECMP nexthops should
hopefully not make this a performance issue.  (Also, nexthops should be
hot in the caches here.)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
David Lamparter David Lamparter da07f5228a063f9cbafde23523ec8bd13b617e75 m da07f5228a063f9cbafde23523ec8bd13b617e75 ospfd: fix clang-SA warning
Need to clear refresh_list before dropping the reference.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>