Build #3,507

FreeRangeRouting Protocol Suite

Build: #3507 failed Changes by Mark Stapp <mjs@voltanet.io>

Build result summary

Details

Completed
Duration
356 minutes
Labels
version=frr-7_4-dev-1995-g7d4b85795git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-3507branch=master
Revision
7d4b857955864f6fd8aa40ebf61f9c3a9dc90041 7d4b857955864f6fd8aa40ebf61f9c3a9dc90041
Total tests
9767
Fixed in
#3510 (Changes by Mark Stapp <mjs@voltanet.io>)

Tests

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Mark Stapp <mjs@voltanet.io> Mark Stapp <mjs@voltanet.io> 7d4b857955864f6fd8aa40ebf61f9c3a9dc90041 7d4b857955864f6fd8aa40ebf61f9c3a9dc90041 Merge pull request #6705 from sworleys/PBR-Fixes-More
pbrd: A couple pbr fixes
Stephen Worley <sworley@cumulusnetworks.com> Stephen Worley <sworley@cumulusnetworks.com> 09813729c7625ff81056f24763d620f7d33251fa m 09813729c7625ff81056f24763d620f7d33251fa pbrd: nhgc state improvements when installed/removed
Cleanup the marking of a nhc as installed/removed based on table
route installation.

We were not even handling the removal state at all.

We saw some timing issues with the routes being installed/removed
multiple times and then never resending the pbr map due to bad states
on the nhgc.

Dont worry about checking if its already marked installed before
scheduling the policy walk. We have a check in `pbr_send_map()`
to ensure we dont try to resend a map sequence already installed.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
Stephen Worley <sworley@cumulusnetworks.com> Stephen Worley <sworley@cumulusnetworks.com> 6db1188f0e3f3ad407cf45a7190800c00ca6bb26 m 6db1188f0e3f3ad407cf45a7190800c00ca6bb26 pbrd: uninstall NHG route if not valid anymore
Withdraw route from RIB if we detect the NHG is not valid
anymore. We were seeing an issue where we would leave a route
in zebra's RIB if it was recursive despite it being removed
from the kernel due to an interface going down.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>

Tests

New test failures 2
Status Test View job Duration
Collapse Failed test_bgp_instance_del_test test_adjacencies History
TopoTests Ubuntu 16.04 arm8 Part 2 8 mins
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed
Collapse Failed test_bgp_l3vpn_to_bgp_vrf test_adjacencies History
TopoTests Ubuntu 16.04 arm8 Part 2 6 mins
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed

Jira issues

IssueDescriptionStatus
Unknown Issue TypeFRR-7Could not obtain issue details from Jira