Build #3,521

FreeRangeRouting Protocol Suite

Build: #3521 failed Changes by Quentin Young

Build result summary

Details

Completed
Duration
445 minutes
Labels
version=frr-7_4-dev-2040-g807b45404git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-3521branch=master
Revision
807b4540435229eba6e2fc88fa6f80f88e9269f1 807b4540435229eba6e2fc88fa6f80f88e9269f1
Total tests
9767
Failing since
#3518 (Changes by David Lamparter)
Fixed in
#3537 (Changes by Russ White <russ@riw.us>)

Tests

Responsible

Code commits

Author Commit Message Commit date
Quentin Young Quentin Young 807b4540435229eba6e2fc88fa6f80f88e9269f1 807b4540435229eba6e2fc88fa6f80f88e9269f1 Merge pull request #6435 from idryzhov/fix-no-vrf
vtysh: return success from "no vrf" when VRF doesn't exist
Igor Ryzhov <iryzhov@nfware.com> Igor Ryzhov <iryzhov@nfware.com> cd980d0375a45dc885a1781d00a6654e58f4396b m cd980d0375a45dc885a1781d00a6654e58f4396b vtysh: return success from "no vrf" when VRF doesn't exist
It is possible that the same VRF exists in one daemon and doesn't exist
in another. In this case, "no vrf NAME" command execution will stop on
the first daemon without the VRF and it won't be possible to delete the
VRF from other daemons.

Such behavior can be reproduced with the following steps:
```
# ip link add test type vrf table 1
# vtysh -c "conf t" -c "vrf test" -c "ip route 1.1.1.1/32 blackhole"
# vtysh -c "show run"
...
vrf test
 ip route 1.1.1.1/32 blackhole
 exit-vrf
!
...
# ip link del test
# vtysh -c "conf t" -c "no vrf test"
% VRF test does not exist
# vtysh -c "show run"
...
vrf test
 ip route 1.1.1.1/32 blackhole
 exit-vrf
!
...
```

This commit fixes the issue by returning success from "no vrf" command
when VRF doesn't exist.

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

Tests

Existing test failures 2
Status Test Failing since View job Duration
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed

Jira issues

IssueDescriptionStatus
Unknown Issue TypeFRR-7Could not obtain issue details from Jira