Build #3,532

FreeRangeRouting Protocol Suite

Build result summary

Details

Completed
Duration
540 minutes
Labels
version=frr-7_4-dev-2075-gdb8a7160dgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-3532branch=master
Revision
db8a7160daedd31f22c3380c9c7e579b3a2d3449 db8a7160daedd31f22c3380c9c7e579b3a2d3449
Total tests
9819
Failing since
#3518 (Changes by David Lamparter)
Fixed in
#3537 (Changes by Russ White <russ@riw.us>)

Responsible

Code commits

Author Commit Message Commit date
Donatas Abraitis <donatas.abraitis@gmail.com> Donatas Abraitis <donatas.abraitis@gmail.com> db8a7160daedd31f22c3380c9c7e579b3a2d3449 db8a7160daedd31f22c3380c9c7e579b3a2d3449 Merge pull request #6803 from donaldsharp/coverity_moo_moo
Coverity code cleanup
Donald Sharp Donald Sharp 5f140efeeffdd9951456701b78a70a71b879be5a m 5f140efeeffdd9951456701b78a70a71b879be5a bgpd: Deref after null check in bgp_evpn_vty.c
Coverity has noticed that we are using bgp_evpn after
we have already NULL checked it one time.  Add an assert
to make Coverity happy here, if we get to this point
something terrible has happened.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp Donald Sharp 7b3a38053141a3ebfc5b039bc191c5e08d8b9cef m 7b3a38053141a3ebfc5b039bc191c5e08d8b9cef bgpd: Prevent Null pointer usage
Coverity rightly points out that bgp_table_top might return
NULL and immediately deref'ing it might be a problem.
Add a bit of safety.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp Donald Sharp 3130e2868685e7714aa1a90d83320df05addb3a3 m 3130e2868685e7714aa1a90d83320df05addb3a3 bgpd: Comment out dead code for future
I wanted to preserve the old code flow to see what might
be needed in the future in commit:
23ca3269da5f9d898cb54d42c560d519b9cb9915

Coverity doesn't like dead code.  So let's comment it out.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Tests

Existing test failures 2
Status Test Failing since View job Duration
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed
AssertionError: 2 tests failed
E   AssertionError: 2 tests failed

Jira issues

IssueDescriptionStatus
Unknown Issue TypeFRR-7Could not obtain issue details from Jira