FreeRangeRouting Protocol Suite

Build: #4897 was successful Changes by Donald Sharp

Stages & jobs

  1. Get Sourcecode

  2. Building Stage

  3. Basic Tests

  4. Final

    Final

Build result summary

Details

Completed
Duration
257 minutes
Labels
version=8_1-dev-767-g918af5a40git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-4897branch=master
Revision
918af5a40bb181a5878fb8f2b9a780bd2dbc72b4 918af5a40bb181a5878fb8f2b9a780bd2dbc72b4
Total tests
12748
First to pass since
#4892 (Changes by Russ White <russ@riw.us>)

Tests

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 918af5a40bb181a5878fb8f2b9a780bd2dbc72b4 918af5a40bb181a5878fb8f2b9a780bd2dbc72b4 Merge pull request #9102 from opensourcerouting/autoconf-fix-gcov
build: fix LDFLAGS confusion & gcov
David Lamparter David Lamparter 81aff2127f35da2ec667bc60989cac7df7a8ef48 m 81aff2127f35da2ec667bc60989cac7df7a8ef48 build: use `--coverage` for gcov
libtool does not understand `-coverage` with a single dash.  Official
gcc docs also say `--coverage` rather than `-coverage`.  (clang lists
both.)

Also, for correct linking, libtool needs `--coverage` in LDFLAGS as
opposed to `-lgcov` (with the latter you get library ordering/deps
issues)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
David Lamparter David Lamparter 63116a7008706988136785ffa011cefee0355193 m 63116a7008706988136785ffa011cefee0355193 build: fix `AM_LDFLAGS` usage (and gcov)
like the other automake variables, setting `xyz_LDFLAGS` causes
`AM_LDFLAGS` to be ignored for `xyz`.  For some reason I had in my mind
that automake doesn't do this for LDFLAGS, but... it does.  (Which is
consistent with `_CFLAGS` and co.)

So, all the libraries and modules have been ignoring `AM_LDFLAGS` (which
includes `SAN_FLAGS` too).  Set up new `LIB_LDFLAGS` and
`MODULE_LDFLAGS` to handle all of this correctly (and move these bits to
a central location.)

Fixes: #9034
Fixes: 0c4285d77eb ("build: properly split CFLAGS from AC_CFLAGS")
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Tests

Fixed tests 1
Status Test Failing since View job Duration
Successful test_bfd_topo2 test_protocols_convergence History
Failing since build #4894 (Changes by Donatas Abraitis <donatas.abraitis@gmail.com>) TopoTests Ubuntu 18.04 amd64 Part 1 30 secs
Successful RFC-Compliance-tests ANVL-BGP-AS4-2.6 History
Failing since build #4896 (Changes by Donald Sharp and Igor Ryzhov <iryzhov@nfware.com>) IPv4 Protocols on Ubuntu 18.04 37 secs