Build #3,167

FreeRangeRouting Protocol Suite

Build: #3167 failed Changes by David Lamparter

Build result summary

Details

Completed
Duration
216 minutes
Labels
version=frr-7_4-dev-880-g6b1d9f37egit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr-3167branch=master
Revision
6b1d9f37ec25399bbbb0bfc1c2e33d35877b5c35 6b1d9f37ec25399bbbb0bfc1c2e33d35877b5c35
Total tests
8511

Tests

Responsible

Code commits

Author Commit Message Commit date
David Lamparter David Lamparter 6b1d9f37ec25399bbbb0bfc1c2e33d35877b5c35 6b1d9f37ec25399bbbb0bfc1c2e33d35877b5c35 Merge pull request #6160 from qlyoung/fix-pim-bsm-negative-shift
pimd: fix negative bitshift in BSM code
Quentin Young Quentin Young 817f893343b631f4822f2fd5a596e15ae0c7301f m 817f893343b631f4822f2fd5a596e15ae0c7301f pimd: fix negative bitshift
Valid range for hashmasklen is 0-32 under IPv4; failure to validate this
results in a negative bitshift later

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Tests

New test failures 1
Status Test View job Duration
Collapse Failed test_bgp_as_wide_bgp_identifier test_bgp_as_wide_bgp_identifier History
Topology Tests on Ubuntu 16.04 arm8 1 min
AssertionError: Bad BGP Identifier notification not sent: "TopoGear<name="r3",links=["r3-eth0"<->"s1-eth2"]> TopoRouter<>" assert expected key(s) ['lastNotificationReason'] in json["192.168.255.1"] (have [u'addressFamilyInfo', u'lastResetCode', u'portForeign', u'localAs', u'nexthop', u'hostForeign', u'readThread', u'nexthopGlobal', u'connectionsEstablished', u'bgpTimerLastRead', u'nexthopLocal', u'minBtwnAdvertisementRunsTimerMsecs', u'gracefulRestartInfo', u'bgpInUpdateElapsedTimeMsecs', u'bgpState', u'hostLocal', u'remoteRouterId', u'connectionsDropped', u'nbrInternalLink', u'nextConnectTimerDueInMsecs', u'remoteAs', u'connectRetryTimer', u'bgpTimerHoldTimeMsecs', u'bgpConnection', u'lastResetDueTo', u'writeThread', u'bgpTimerKeepAliveIntervalMsecs', u'lastResetTimerMsecs', u'bgpVersion', u'messageStats', u'bgpTimerLastWrite', u'portLocal', u'localRouterId']):   --- Expected value   +++ Current value   @@ -2 +2,65 @@   -    "lastNotificationReason": "OPEN Message Error/Bad BGP Identifier"   +    "addressFamilyInfo": {   +        "ipv4Unicast": {   +            "acceptedPrefixCounter": 0,    +            "commAttriSentToNbr": "extendedAndStandard"   +        }   +    },    +    "bgpConnection": "sharedNetwork",    +    "bgpInUpdateElapsedTimeMsecs": 19335000,    +    "bgpState": "Active",    +    "bgpTimerHoldTimeMsecs": 180000,    +    "bgpTimerKeepAliveIntervalMsecs": 60000,    +    "bgpTimerLastRead": 68000,    +    "bgpTimerLastWrite": 67000,    +    "bgpVersion": 4,    +    "connectRetryTimer": 120,    +    "connectionsDropped": 0,    +    "connectionsEstablished": 0,    +    "gracefulRestartInfo": {   +        "endOfRibRecv": {},    +        "endOfRibSend": {},    +        "localGrMode": "Helper*",    +        "rBit": false,    +        "remoteGrMode": "NotApplicable",    +        "timers": {   +            "configuredRestartTimer": 120,    +            "receivedRestartTimer": 0   +        }   +    },    +    "hostForeign": "192.168.255.1",    +    "hostLocal": "192.168.255.3",    +    "lastResetCode": 32,    +    "lastResetDueTo": "Waiting for peer OPEN",    +    "lastResetTimerMsecs": 68000,    +    "localAs": 65002,    +    "localRouterId": "10.10.10.10",    +    "messageStats": {   +        "capabilityRecv": 0,    +        "capabilitySent": 0,    +        "depthInq": 0,    +        "depthOutq": 0,    +        "keepalivesRecv": 0,    +        "keepalivesSent": 0,    +        "notificationsRecv": 0,    +        "notificationsSent": 0,    +        "opensRecv": 0,    +        "opensSent": 1,    +        "routeRefreshRecv": 0,    +        "routeRefreshSent": 0,    +        "totalRecv": 0,    +        "totalSent": 1,    +        "updatesRecv": 0,    +        "updatesSent": 0   +    },    +    "minBtwnAdvertisementRunsTimerMsecs": 0,    +    "nbrInternalLink": true,    +    "nextConnectTimerDueInMsecs": 53000,    +    "nexthop": "192.168.255.3",    +    "nexthopGlobal": "::",    +    "nexthopLocal": "::",    +    "portForeign": 179,    +    "portLocal": 59376,    +    "readThread": "off",    +    "remoteAs": 65002,    +    "remoteRouterId": "0.0.0.0",    +    "writeThread": "off"
E   AssertionError: Bad BGP Identifier notification not sent: "TopoGear<name="r3",links=["r3-eth0"<->"s1-eth2"]> TopoRouter<>"
    assert expected key(s) ['lastNotificationReason'] in json["192.168.255.1"] (have [u'addressFamilyInfo', u'lastResetCode', u'portForeign', u'localAs', u'nexthop', u'hostForeign', u'readThread', u'nexthopGlobal', u'connectionsEstablished', u'bgpTimerLastRead', u'nexthopLocal', u'minBtwnAdvertisementRunsTimerMsecs', u'gracefulRestartInfo', u'bgpInUpdateElapsedTimeMsecs', u'bgpState', u'hostLocal', u'remoteRouterId', u'connectionsDropped', u'nbrInternalLink', u'nextConnectTimerDueInMsecs', u'remoteAs', u'connectRetryTimer', u'bgpTimerHoldTimeMsecs', u'bgpConnection', u'lastResetDueTo', u'writeThread', u'bgpTimerKeepAliveIntervalMsecs', u'lastResetTimerMsecs', u'bgpVersion', u'messageStats', u'bgpTimerLastWrite', u'portLocal', u'localRouterId']):
      --- Expected value
      +++ Current value
      @@ -2 +2,65 @@
      -    "lastNotificationReason": "OPEN Message Error/Bad BGP Identifier"
      +    "addressFamilyInfo": {
(64 more lines...)