Build #20

FreeRangeRouting Protocol Suite

Build: #20 failed Changes by Donald Sharp and Christian Franke

Build result summary

Details

Completed
Duration
163 minutes
Labels
version=frr-7_1-dev-2535-gd39a09b54git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-frr46-20branch=dev/7_2
Revision
d39a09b5479ddc71c765839d1a79f9d079d6c766 d39a09b5479ddc71c765839d1a79f9d079d6c766
Total tests
7647
Fixed in
#22 (Changes by Renato Westphal)
No failed tests found, a possible compilation error occurred.

Tests

Responsible

Comments on Ubuntu 16.04 i386 build

  1. Anonymous user

    Detected hung build state. Attempting to generate stack trace and terminate spawned sub-processes.

  2. Anonymous user

    Detected hung build state. Attempting to generate stack trace and terminate spawned sub-processes... - HungBuildKiller Plugin

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp d39a09b5479ddc71c765839d1a79f9d079d6c766 d39a09b5479ddc71c765839d1a79f9d079d6c766 Merge pull request #5089 from cfra/fix/7.2/isis-threeway
isisd: Fix handling of neighbor circuit id in three way handshake
Christian Franke Christian Franke 2028040307fc3511b4fb715e454f10f895dcfd35 2028040307fc3511b4fb715e454f10f895dcfd35 isisd: Fix handling of neighbor circuit id in three way handshake
RFC 5303 states:

      If the system ID and Extended Local Circuit ID of the neighboring
      system are known (in adjacency three-way state Initializing or
      Up), the neighbor's system ID SHALL be reported in the Neighbor
      System ID field, and the neighbor's Extended Local Circuit ID
      SHALL be reported in the Neighbor Extended Local Circuit ID field.

There is nothing written about only setting the Extended circuit ID of the
adjacency only when we bring the three-way adjacency up.

In fact, we should always update it, to avoid the problem described in #4783.

Fixes: #4783
Signed-off-by: Christian Franke <chris@opensourcerouting.org>