Build #843

RPKI Build for FRR

Build: #843 failed Changes by David Lamparter

Build result summary

Details

Completed
Duration
35 minutes
Labels
version=frr-7_1-dev-177-g0240fee6fgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-rpki-843branch=master
Revision
0240fee6f4befabc84b16dae97dae986283dd9b9 0240fee6f4befabc84b16dae97dae986283dd9b9
Fixed in
#844 (Changes by David Lamparter)

No failed tests found, a possible compilation error occurred.

Responsible

Comments on ci015_fedora24_amd64 build

  1. Anonymous user

    Detected hung build state. Attempting to generate stack trace and terminate spawned sub-processes.

  2. Anonymous user

    Detected hung build state. Attempting to generate stack trace and terminate spawned sub-processes... - HungBuildKiller Plugin

Code commits

Author Commit Message Commit date
David Lamparter David Lamparter 0240fee6f4befabc84b16dae97dae986283dd9b9 0240fee6f4befabc84b16dae97dae986283dd9b9 Merge pull request #3715 from qlyoung/fix-systemd-deps
tools: fix systemd dependency graph
Quentin Young Quentin Young efbf903d61180abd5e1d53fc1a73b87f5039ff30 m efbf903d61180abd5e1d53fc1a73b87f5039ff30 tools: fix systemd dependency graph
Currently our systemd dependencies look something like this (example
from vanilla Debian 9):

$ systemctl list-dependencies frr
frr.service
● ├─system.slice
● └─sysinit.target
  ...

$ systemctl list-dependencies --reverse frr
frr.service
● └─network-online.target
●   └─apt-daily.service

Note that sysinit.target does not depend on any network* service or
target.

In other words, unless there is a service that requires
network-online.service, even if FRR is enabled it will not be started.
Therefore network-online.target is the wrong unit to have in WantedBy=,
as it is not always started.

This patch updates our service file so that it is properly started by
the system when enabled, delayed until networking is up, and if possible
delayed until after NetworkManager, systemd-networkd or any other
networking configuration manager has finished performing its tasks -
i.e. after network-online.target.

After these changes our new dependency graph looks like this:

$ systemctl list-dependencies frr
frr.service
● ├─system.slice
● │ └─networking.service
● ├─network.target
● └─sysinit.target
  ...

$ systemctl list-dependencies --reverse frr
frr.service
● └─multi-user.target
●   └─graphical.target

This way, FRR will be started by multi-user.target (just like most
applications), but delayed until after networking has been configured.

In the same stroke, this should also fix issues on systems that do not
provide "networking.service" (such as CentOS 7).

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@diac24.net>