Build #857

RPKI Build for FRR

Build: #857 was successful Changes by Donald Sharp

Build result summary

Details

Completed
Duration
58 minutes
Labels
version=frr-7_1-dev-221-gcfef27e56git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-rpki-857branch=master
Revision
cfef27e56ef3246a261ee0bf2810a46c08eebf8f cfef27e56ef3246a261ee0bf2810a46c08eebf8f
Successful since
#844 ()

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp cfef27e56ef3246a261ee0bf2810a46c08eebf8f cfef27e56ef3246a261ee0bf2810a46c08eebf8f Merge pull request #3622 from mjstapp/fix_cpp_compile
libs, daemons: changes to permit c++ compilation
Renato Westphal Renato Westphal c139972c0ffcabe73cafc3d20f257163fa81ddd0 m c139972c0ffcabe73cafc3d20f257163fa81ddd0 lib: rename enum to avoid conflict
Two different definitions of "enum filter_type" exist in libfrr:
one in lib/filter.h and other in lib/command_match.h. Rename one
of them to resolve a conflict that happens when both headers are
included by the same file.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Renato Westphal Renato Westphal 7f04943d6b860f5e74a8fc652a106c3a2046a0ce m 7f04943d6b860f5e74a8fc652a106c3a2046a0ce lib: a few more trivial changes for C++ compatibility
* command_graph.h: stop using "new" as a parameter name as that's a
  reserved C++ keyword.

* module.h: avoid using C99 designated initializers since C++ doesn't
  support them. This change hurts code readability quite considerably,
  so we should try to find a better solution later.

* pw.h: remove unneeded empty structure to silence a C++ warning.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Renato Westphal Renato Westphal 5e2444690bd0d2003e7d283f890b33e11ddd371f m 5e2444690bd0d2003e7d283f890b33e11ddd371f lib: add extern "C" {} blocks to all libfrr headers
These are necessary to use functions defined in these headers from C++.

Signed-off-by: David Lamparter <equinox@diac24.net>
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
David Lamparter David Lamparter 8ed561e1f13d0afb019a7963238bdd43ad017bec m 8ed561e1f13d0afb019a7963238bdd43ad017bec tests: add C++ header compatibility smoke test
Compiling an empty C file with most headers included and -Wc++-compat
gives us a build error if we introduce some stupid C++-incompatible
change.

While this won't catch everything, it's a good start.

Signed-off-by: David Lamparter <equinox@diac24.net>