Build #928

RPKI Build for FRR

Build: #928 failed Changes by David Lamparter

Build result summary

Details

Completed
Duration
14 minutes
Labels
version=frr-7_1-dev-484-g6e727402bgit=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-rpki-928branch=master
Revision
6e727402bd7ac17028af98773b21ac020fa80a57 6e727402bd7ac17028af98773b21ac020fa80a57
Failing since
#882 (Child of FRR-FRR-1956)

No failed tests found, a possible compilation error occurred.

Responsible

This build has been failing since #882
No one has taken responsibility

Code commits

Author Commit Message Commit date
David Lamparter David Lamparter 6e727402bd7ac17028af98773b21ac020fa80a57 6e727402bd7ac17028af98773b21ac020fa80a57 Merge pull request #3907 from donaldsharp/pim_election
pimd: Ensure DR election happens when both sides change prio
David Lamparter David Lamparter 83152933da940c16ce8aa9c18da5a4d6a0c239bb 83152933da940c16ce8aa9c18da5a4d6a0c239bb Merge pull request #3898 from dslicenc/peer-group-remote-as
bpgd: resolve more neighbor peer-group issues
Donald Sharp Donald Sharp 3de708125ec2f2d737bd5e6285a8e6ab23fed094 m 3de708125ec2f2d737bd5e6285a8e6ab23fed094 pimd: Ensure DR election happens when both sides change prio
Suppose we have 2 routers A and B.  Both Router A and B have
the same priority of 1000.  Router A is the elected DR.
Now suppose B lowers his priority to 1.  He still looses the
DR election and we are not sending a hello with the new priority.
Immediately after this A's priority is also lowered to 1, it
looses the election and sends the hello.  B receives this hello
and elects A as the DR( since it has the better ip address)
At this point A believes B is the DR, and B believes A is the
DR until such time that the normal hello from B is sent to A,
which if timed correctly can be a significant amount of time).

This code just causes a hello to be sent if the priority is
changed.  Now both sides will be able to converge quickly

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Don Slice <dslice@cumulusnetworks.com> Don Slice <dslice@cumulusnetworks.com> 390485fdc96dbdd56c42d1db5d73c985411f8b4b m 390485fdc96dbdd56c42d1db5d73c985411f8b4b bpgd: resolve more neighbor peer-group issues
Found in testing that in a certain sequence, a neighbor's peer-group
membership would be lost.  This fix resolves that issue. Additionally
found that "no neighbor swp1 remote-as 2" would sometimes leave the
config with "neighbor swp1 remote-as 0" rather than removing from the
config. That one is also resolved.

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>

Shared artifacts

Artifact File size
VersionInfo 679 bytes
SourceCode 5 MB
CentOS 7 x86_64 RPKI RPMs 14 MB
CentOS 6 x86_64 RPKI RPMs 13 MB
Fedora 24 x86_64 RPKI RPMs 14 MB