Build #935

RPKI Build for FRR

Build: #935 failed Changes by Donald Sharp

Build result summary

Details

Completed
Duration
10 minutes
Labels
version=frr-7_1-dev-519-g86dd09667git=https_//github_com/frrouting/frr_gitbuildurl=https_//ci1_netdef_org/browse/frr-rpki-935branch=master
Revision
86dd09667aad80fbd7f3e8d878f1733ebeda4f20 86dd09667aad80fbd7f3e8d878f1733ebeda4f20
Failing since
#882 (Child of FRR-FRR-1956)

No failed tests found, a possible compilation error occurred.

Responsible

This build has been failing since #882
No one has taken responsibility

Code commits

Author Commit Message Commit date
Donald Sharp Donald Sharp 86dd09667aad80fbd7f3e8d878f1733ebeda4f20 86dd09667aad80fbd7f3e8d878f1733ebeda4f20 Merge pull request #3920 from AkhileshSamineni/show_bgp_ipv6_summary_fix_master
bgpd: Incorrect number of peers count in "show bgp ipv6 summary" output
Donald Sharp Donald Sharp 7bc2b18cb4a1bb027169269b13def3c2cf3d97fb 7bc2b18cb4a1bb027169269b13def3c2cf3d97fb Merge pull request #3900 from opensourcerouting/ripd-fix-no-passive-iface
ripd: fix removal of configured passive interfaces
Donald Sharp Donald Sharp 6e65fa2b6d14f6fa160c0d97d53ba876f9dbf71f 6e65fa2b6d14f6fa160c0d97d53ba876f9dbf71f Merge pull request #3902 from opensourcerouting/fix-removal-np-containers
lib: fix removal of yang non-presence containers
Akhilesh Samineni <akhilesh.samineni@broadcom.com> Akhilesh Samineni <akhilesh.samineni@broadcom.com> 210ec2a0d63263be7178d494e044d6e570cd2f16 m 210ec2a0d63263be7178d494e044d6e570cd2f16 bgpd: Incorrect number of peers count in "show bgp ipv6 summary output
The "show bgp ipv6 summary" output displays incorrect number of peers count.

sonic# show bgp ipv6 summary

IPv6 Unicast Summary:
BGP router identifier 10.1.0.1, local AS number 65100 vrf-id 0
BGP table version 0
RIB entries 0, using 0 bytes of memory
Peers 5, using 103 KiB of memory
Peer groups 1, using 64 bytes of memory

Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd
2003::1 4 65099 0 0 0 0 0 never Active
2088::1 4 65100 0 0 0 0 0 never Active
3021::2 4 65100 0 0 0 0 0 never Active

Total number of neighbors 3
sonic#
In the above output, the peers count displays as 5 but the actual peer count is 3, i.e.. 3 neighbors are activated in ipv6 unicast address family.
Displayed peer count (5) is the number of the neighbors activated in a BGP instance.

Fix : Now the peers count displays the number of neighbors activated per afi/safi.
After Fix:
sonic# show bgp ipv6 summary

IPv6 Unicast Summary:
BGP router identifier 10.1.0.1, local AS number 65100 vrf-id 0
BGP table version 0
RIB entries 0, using 0 bytes of memory
Peers 3, using 62 KiB of memory
Peer groups 1, using 64 bytes of memory

Neighbor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd
2003::1 4 65099 0 0 0 0 0 never Active
2088::1 4 65100 0 0 0 0 0 never Active
3021::2 4 65100 0 0 0 0 0 never Active

Total number of neighbors 3
sonic#

Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com>
Renato Westphal Renato Westphal 1912caa2caf14936379df830e028d1492a061988 m 1912caa2caf14936379df830e028d1492a061988 lib: fix removal of yang non-presence containers
Non-presence containers don't have "destroy" callbacks. So, once
a np-container is deleted, we need to call the "destroy" callbacks
of its child nodes instead.

This commit doesn't fix any real problem as of now since all
np-containers from the FRR YANG modules contain or one more mandatory
child nodes, so they can't be deleted (libyang will add missing
np-containers when validating data). Nevertheless, upcoming YANG
modules should benefit from this change.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

Shared artifacts

Artifact File size
VersionInfo 679 bytes
SourceCode 5 MB
CentOS 7 x86_64 RPKI RPMs 14 MB
CentOS 6 x86_64 RPKI RPMs 13 MB
Fedora 24 x86_64 RPKI RPMs 14 MB