Testing PullReq against Topology Tests

Build: #395 failed Custom build by Github Hook with revision master

Build result summary

Details

Completed
Duration
24 minutes
Flags
Custom revisionCustom build
Labels
version=frr-7_1-dev-898-gbb6bf8403git=https_//github_com/frrouting/topotests_gitbuildurl=https_//ci1_netdef_org/browse/frr-topopr-cf-395branch=master
Revisions
FRR - Topotests
ece4754f426a67e1f9bebfd8d2128bd10f1a0034 ece4754f426a67e1f9bebfd8d2128bd10f1a0034
FRR - FreeRangeRouting
bb6bf8403554c7c5bc904090867856c9ac19e3ef bb6bf8403554c7c5bc904090867856c9ac19e3ef
Total tests
620
Failing since
#394 (Custom build by Github Hook with revision master)

Tests

Custom variables

Custom revision
ece4754f426a67e1f9bebfd8d2128bd10f1a0034 ece4754f426a67e1f9bebfd8d2128bd10f1a0034
Name Value
github_base_sha ece4754f426a67e1f9bebfd8d2128bd10f1a0034
github_pullreq 147
github_branch master
github_repo FRRouting/topotests
github_merge_sha c1e46b8b4836e8e01ea3c7bd42b2d0c7f8fde2be

Comments

  1. Github Hook

    GitHub Merge Request 147
    for GitHub Repo FRRouting/topotests, branch master

    Request to merge from qlyoung/topotests
    Merge Git Commit ID c1e46b8b4836e8e01ea3c7bd42b2d0c7f8fde2be on top of base Git Commit ID ece4754f426a67e1f9bebfd8d2128bd10f1a0034

Code commits

FRR - Topotests
Author Commit Message Commit date
Christian Franke Christian Franke ece4754f426a67e1f9bebfd8d2128bd10f1a0034 ece4754f426a67e1f9bebfd8d2128bd10f1a0034 Fix README update
FRR - FreeRangeRouting
Author Commit Message Commit date
Quentin Young Quentin Young bb6bf8403554c7c5bc904090867856c9ac19e3ef bb6bf8403554c7c5bc904090867856c9ac19e3ef Merge pull request #4156 from ton31337/fix/allow_backslash_in_as-path_regexp
bgpd: Allow backslash in as-path filter lists
Mark Stapp <mjs@voltanet.io> Mark Stapp <mjs@voltanet.io> c02a40c14fec005d419ad1dbd3fac0e9521b9c6f c02a40c14fec005d419ad1dbd3fac0e9521b9c6f Merge pull request #4165 from dslicenc/rnh-invalid-nexthops
zebra: stop sending invalid nexthops to clients
Don Slice <dslice@cumulusnetworks.com> Don Slice <dslice@cumulusnetworks.com> e47c4d3cfe7bf7c97f4b10fc6347f484093f14bd e47c4d3cfe7bf7c97f4b10fc6347f484093f14bd zebra: stop sending invalid nexthops to clients
Found that zebra_rnh_apply_nht_rmap would set the
NEXTHOP_FLAG_ACTIVE if not blocked by the route-map, even
if the flag was not active prior to the check.  This fix
changes the flag used to denote the nexthop is filtered so
that proper active state can be retained. Additionally,
found two cases where we would send invalid nexthops via
send_client, which would also cause this crash.  All three
fixed in this commit.

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Quentin Young Quentin Young fd3938ac3dd36b4c09ec5023769dd4cfc6ee0fc6 fd3938ac3dd36b4c09ec5023769dd4cfc6ee0fc6 Merge pull request #4164 from opensourcerouting/rm-ports
ports: remove abandoned ports subdirectory

Tests

New test failures 5
Status Test View job Duration
Collapse Failed test_all_protocol_startup test_router_running History
TopoTest 2.0 Branch 8 secs
AssertionError: r1: Daemon isisd not running assert 'r1: Daemon isisd not running' == ''   - r1: Daemon isisd not running
E   AssertionError: r1: Daemon isisd not running
    assert 'r1: Daemon isisd not running' == ''
      - r1: Daemon isisd not running
Collapse Failed test_all_protocol_startup test_bgp_ipv6_summary History
TopoTest 3.0 Branch < 1 sec
AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:   --- actual SHOW BGP IPv6 SUMMARY   +++ expected SHOW BGP IPv6 SUMMARY   @@ -1,7 +1,7 @@    BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0    BGP table version 1    RIB entries 1, using XXXX bytes of memory   -Peers 4, using XXXX KiB of memory   +Peers 2, using XXXX KiB of memory        Neighbor         V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd    fc00:0:0:8::1000 4        100       0       0        0    0    0    never       Active assert 1 == 0   -1   +0
E   AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:
      --- actual SHOW BGP IPv6 SUMMARY
      +++ expected SHOW BGP IPv6 SUMMARY
      @@ -1,7 +1,7 @@
       BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
       BGP table version 1
       RIB entries 1, using XXXX bytes of memory
(8 more lines...)
Collapse Failed test_all_protocol_startup test_bgp_ipv6_summary History
TopoTest 4.0 Branch < 1 sec
AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:   --- actual SHOW BGP IPv6 SUMMARY   +++ expected SHOW BGP IPv6 SUMMARY   @@ -1,7 +1,7 @@    BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0    BGP table version 1    RIB entries 1, using XXXX bytes of memory   -Peers 4, using XXXX KiB of memory   +Peers 2, using XXXX KiB of memory        Neighbor         V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd    fc00:0:0:8::1000 4        100       0       0        0    0    0    never       Active assert 1 == 0   -1   +0
E   AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:
      --- actual SHOW BGP IPv6 SUMMARY
      +++ expected SHOW BGP IPv6 SUMMARY
      @@ -1,7 +1,7 @@
       BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
       BGP table version 1
       RIB entries 1, using XXXX bytes of memory
(8 more lines...)
Collapse Failed test_all_protocol_startup test_bgp_ipv6_summary History
TopoTest 5.0 Branch < 1 sec
AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:   --- actual SHOW BGP IPv6 SUMMARY   +++ expected SHOW BGP IPv6 SUMMARY   @@ -1,7 +1,7 @@    BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0    BGP table version 1    RIB entries 1, using XXXX bytes of memory   -Peers 4, using XXXX KiB of memory   +Peers 2, using XXXX KiB of memory        Neighbor         V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd    fc00:0:0:8::1000 4        100       0       0        0    0    0    never       Active assert 1 == 0   -1   +0
E   AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:
      --- actual SHOW BGP IPv6 SUMMARY
      +++ expected SHOW BGP IPv6 SUMMARY
      @@ -1,7 +1,7 @@
       BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
       BGP table version 1
       RIB entries 1, using XXXX bytes of memory
(8 more lines...)
Collapse Failed test_all_protocol_startup test_bgp_ipv6_summary History
TopoTest 6.0 Branch < 1 sec
AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:   --- actual SHOW BGP IPv6 SUMMARY   +++ expected SHOW BGP IPv6 SUMMARY   @@ -1,7 +1,7 @@    BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0    BGP table version 1    RIB entries 1, using XXXX bytes of memory   -Peers 4, using XXXX KiB of memory   +Peers 2, using XXXX KiB of memory        Neighbor         V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd    fc00:0:0:8::1000 4        100       0       0        0    0    0    never       Active assert 1 == 0   -1   +0
E   AssertionError: SHOW BGP IPv6 SUMMARY failed for router r1:
      --- actual SHOW BGP IPv6 SUMMARY
      +++ expected SHOW BGP IPv6 SUMMARY
      @@ -1,7 +1,7 @@
       BGP router identifier 192.168.0.1, local AS number 100 vrf-id 0
       BGP table version 1
       RIB entries 1, using XXXX bytes of memory
(8 more lines...)

Shared artifacts

Artifact File size
VersionInfo 784 bytes
SourceCode 5 MB
topotests 534 KB