Testing PullReq against Topology Tests

Build: #58 was successful Custom build by Github Hook with revision master

Build result summary

Details

Completed
Duration
20 minutes
Flags
Custom revisionCustom build
Labels
version=frr-3_0-rc1-2287-g0db8196agit=https_//github_com/frrouting/topotests_gitbuildurl=https_//ci1_netdef_org/browse/frr-topopr-cf-58branch=master
Revisions
FRR - Topotests
master master
FRR - FreeRangeRouting
0db8196a967778a8d4e1018329b635b5716d6a08 0db8196a967778a8d4e1018329b635b5716d6a08
Total tests
252
Successful since
#56 ()

Custom variables

Custom revision
master master
Name Value
github_base_sha 886e31b48d8664ccf96d0d18f6ae7eece74f56e0
github_pullreq 46
github_branch master
github_repo FRRouting/topotests
github_merge_sha cb95701305016f4c5e020a8a45209cdad7e0937d

Comments

  1. Github Hook

    GitHub Merge Request 46
    for GitHub Repo FRRouting/topotests, branch master

    Request to merge from opensourcerouting/topotests
    Merge Git Commit ID cb95701305016f4c5e020a8a45209cdad7e0937d on top of base Git Commit ID 886e31b48d8664ccf96d0d18f6ae7eece74f56e0

Code commits

FRR - Topotests
Author Commit Message Commit date
Martin Winter Martin Winter 886e31b48d8664ccf96d0d18f6ae7eece74f56e0 886e31b48d8664ccf96d0d18f6ae7eece74f56e0 Merge pull request #45 from opensourcerouting/version_cmp_regression1
topotest: fix a regression in version_cmp
FRR - FreeRangeRouting
Author Commit Message Commit date
Juergen Kammer <j.kammer@eurodata.de> Juergen Kammer <j.kammer@eurodata.de> 0db8196a967778a8d4e1018329b635b5716d6a08 0db8196a967778a8d4e1018329b635b5716d6a08 ospf6d: Fix setting interface ipv6 ospf6 cost value (LSA hooks were never called)
Fixes: #1420
Signed-off-by: Juergen Kammer <j.kammer@eurodata.de>

If the ipv6 ospf6 cost on an interface is changed, no recalculation of routes happens, though the interface structure is updated with the new value. The new cost will be used later, when LSA hooks are called for any other reason.

Diagnosis:
The DEFUN for the config command sets oi->cost and calls ospf6_interface_recalculate_cost(oi) whenever there is a change in the supplied value. ospf6_interface_recalculate_cost then gets the new cost for the interface by calling ospf6_interface_get_cost(oi), which returns oi->cost if a cost is manually set (i.e. we get the value we just set). ospf6_interface_recalculate_cost only calls the LSA hooks if there is a change - which obviously never happens if we compare the new value with itself.
Donald Sharp Donald Sharp ccd2b0e6ce0dbbd8e26a0c98f7d574c0f37d55b9 ccd2b0e6ce0dbbd8e26a0c98f7d574c0f37d55b9 Merge pull request #1391 from LabNConsulting/working/master/patch-set/vnc-vrf-export
Support vrf export/import based on vrf-policy
Lou Berger Lou Berger 9d912f0f39d41be2db86cb484dd4cc213ccb4efa 9d912f0f39d41be2db86cb484dd4cc213ccb4efa bgpd: document that export mode applies to vrf-policy groups
Signed-off-by: Lou Berger <lberger@labn.net>
Lou Berger Lou Berger f8a1b295e2ddc1732d6fa26314f259de11d86775 f8a1b295e2ddc1732d6fa26314f259de11d86775 .dir-locals.el: show trailing whitespace
Signed-off-by: Lou Berger <lberger@labn.net>

Shared artifacts

Artifact File size
VersionInfo 765 bytes
SourceCode 3 MB
topotests 245 KB