RTRLIB-Pull-Request Testing

Build: #73 was successful Custom build by Github Hook with revision master

Build result summary

Details

Completed
Duration
8 minutes
Flags
Custom revisionCustom build
Labels
None
Revision
master master
First to pass since
#70 (Custom build by Github Hook with revision 989d20c3e1ad9404c89d7dc09281fd871531fc8c)

Custom variables

Custom revision
master master
Name Value
github_base_sha db2d254d75b835abb169f2f9e4a8cfbe74a3c365
github_pullreq 210
github_branch master
github_repo rtrlib/rtrlib
github_merge_sha 2b25ae5e33be52c4bfb25035b715815a6bb7070c

Comments

  1. Github Hook

    GitHub Merge Request 210
    for GitHub Repo rtrlib/rtrlib, branch master

    Request to merge from opensourcerouting/rtrlib
    Merge Git Commit ID 2b25ae5e33be52c4bfb25035b715815a6bb7070c on top of base Git Commit ID db2d254d75b835abb169f2f9e4a8cfbe74a3c365

Code commits

Author Commit Message Commit date
Marcel Röthke <marcel.roethke@haw-hamburg.de> Marcel Röthke <marcel.roethke@haw-hamburg.de> db2d254d75b835abb169f2f9e4a8cfbe74a3c365 db2d254d75b835abb169f2f9e4a8cfbe74a3c365 rtrlib/rtr: Ensure shadow tables are only freed when initialized (#204)
From the Bug report:
> If rtr_receive_pdu returns an error code, the execution flow is
> redirected to the cleanup label. If ->is_resetting is now true (e.g.,
> because it was set by a CACHE_RESPONSE PDU processed by
> rtr_handle_cache_response_pdu), pfx_table_free_without_notify and
> spki_table_free_without_notify are executing multiple operations on this
> uninitialized data.

This patch ensures the cleanup code can check whether the shadow tables
have been initialized and only frees them if they are.