FRR PR 8144 with Libyang2 branch by Chopps

Build: #13 failed Code changes detected

Stages & jobs

  1. Get Sourcecode

  2. Building Stage

  3. Basic Tests

  4. Final

    Final

Build result summary

Details

Completed
Duration
212 minutes
Labels
version=frr-7_4-dev-5468-gc033d211fgit=https_//github_com/labnconsulting/frr_gitbuildurl=https_//ci1_netdef_org/browse/testing-libyang2chopps-13branch=chopps/ly2
Revision
c033d211fecff8077eeda53edbc6cbb3f1945d5d c033d211fecff8077eeda53edbc6cbb3f1945d5d
Total tests
11301
Fixed in
#25 (Code changes detected)

Tests

Responsible

No one has taken responsibility for this failure

Code commits

Author Commit Message Commit date
Christian Hopps <chopps@gmail.com> Christian Hopps <chopps@gmail.com> c033d211fecff8077eeda53edbc6cbb3f1945d5d m c033d211fecff8077eeda53edbc6cbb3f1945d5d lib: libyang formatting will squash after ci run
Signed-off-by: Christian Hopps <chopps@gmail.com>
Christian Hopps <chopps@gmail.com> Christian Hopps <chopps@gmail.com> b179652199f09d2188e1c71325896c0eb736c34c m b179652199f09d2188e1c71325896c0eb736c34c lib: libyang2 updates from review
Signed-off-by: Christian Hopps <chopps@labn.net>
Christian Hopps <chopps@gmail.com> Christian Hopps <chopps@gmail.com> 4de1f227861c60bb151684664d966ab9b3fcde4f m 4de1f227861c60bb151684664d966ab9b3fcde4f lib: adapt to version 2 of libyang
Compile with HEAD of `libyang2` branch of:
https://github.com/CESNET/libyang

- Still includes debugging
- look for "XXX chopps" for questions and incomplete
- bulk of conversion work done in libfrr
  - ly2 diff/apply supports callbacks, perhaps this could be leveraged.
- LYS_IMPLICIT is gone, need to implement fix for filtering these
- lys_set_[en|dis]abled no longer present (ly2 says unneeded in compiled
  schema)
- lys_schema_sort is gone

staticd init load time of 10k routes now 6s vs ly1 time of 150s

Signed-off-by: Christian Hopps <chopps@labn.net>

Tests

New test failures 1
Status Test View job Duration
Collapse Failed test_bgp_auth test_prefix_peer_remove_passwords History
TopoTests Ubuntu 18.04 arm8 Part 1 2 mins
AssertionError: R2 could not peer 1.1.1.1 state expected Connect got Established  assert False == True   -False   +True
E   AssertionError: R2 could not peer 1.1.1.1 state expected Connect got Established 
    assert False == True
      -False
      +True