FRR
FRRouting
Tests: 8 of 7016 failed
Duration: 149 minutes
Changes: Who: Quentin Young
Why: Merge pull request #3338 from ton31337/fix/optional_args_for_exclude
bgpd: Optionally remove AS number when using `no set as-path exclude`
Changes by Quentin Young
FRR Release 2.0 Build
FRRouting
Tests: 346 passed
Duration: 69 minutes
Changes: No changes
Manual run by Martin Winter
FRR Release 3.0 Build
FRRouting
Tests: 383 passed
Duration: 79 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR Release 4.0 Build
FRRouting
Tests: 412 passed
Duration: 83 minutes
Changes: No changes
Manual run by Martin Winter
FRR Release 5.0 Build
FRRouting
Tests: 421 passed
Duration: 136 minutes
Changes: Who: Philippe Guibert
Why: zebra: add show pbr iptable dscp information
The iptable configured with dscp displays the dscp value configured.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Philippe Guibert
Why: bgpd: fix recursive call combination
The recursive algorithm was taking into account the fact that all the
bpof structures were filled in. Because the dscp value was not given,
the pkt_len parsing could not be achieved. Now the iteration takes into
account each type according to the previous one, thus guaranting all
parameters to be parsed.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Pascal Mathis <mail@pascalmathis.com>
Why: bgpd: Fix AF-attribute overrides when binding peer
The current implementation of the overrides for peer address-family
attributes suffered a bug, which caused all peer-specific attributes to
be lost when the peer was added to a peer-group which already had that
specific address-family active.

This commit extends the *peer_group2peer_config_copy_af* function to
respect overridden flags properly. Additionally, the arguments of the
macros *PEER_ATTR_INHERIT* and *PEER_STR_ATTR_INHERIT* have been
reordered to be more consistent and easy to read.

This commit also adds further test cases to the BGP peer attributes test
suite, so that this kind of error is being caught in future commits. The
missing AF-attribute *distribute-list* has also been added to the test
suite.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
(cherry picked from commit e7103a9644f32a70a10be8f6372aa9084aa33c2f)

Who: Philippe Guibert
Why: bgpd: align fragment flowspec decoding with tcpflags
As fragment bitmask and tcpflags bitmask in flowspec protocol is encoded
in the same way, it is not necessary to differentiate those two fields.
Moreover, it overrides the initial fragment limit set to 1. It is now
possible to handle multiple framgent values.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Philippe Guibert
Why: bgpd: handle ICMP type and code from flowspec
It is possible for flowspec entries containing ICMP rule to insert PBR
entries based on ICMP type and ICMP code.
Flowspec ICMP filtering can either have icmp type or icmp code or both.
Not all combinations are permitted:
- if icmp code is provided, then it is not possible to derive the
  correct icmp value. This will not be installed
- range of ICMP is authorised or list of ICMP, but not both.
- on receiving a list of ICMPtype/code, each ICMP type is attempted to
  be associated to ICMP code. If not found, then ICMPtype is combined
  with all known ICMP code values associated to that ICMP type.
- if a specific ICMP type/code is needed, despite the ICMP code/type
  combination does not exist, then it is possible to do it by forging a
  FS ICMP type/code specific for that.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

...
Manual run by Martin Winter
FRR Release 6.0 Build
FRRouting
Tests: 522 passed
Duration: 144 minutes
Changes: No changes
Manual run by Martin Winter
FRR-3.0-Snapcraft
FRRouting
Tests: 1322 passed
Duration: 934 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR-4.0-Snapcraft
FRRouting
Tests: 1322 passed
Duration: 944 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR-6.0-Snapcraft
FRRouting
Tests: 1322 passed
Duration: 953 minutes
Changes: Who: David Lamparter
Why: Merge pull request #3131 from donaldsharp/early_6.0
lib: Include compiler.h as early as is possible in the build

Who: Quentin Young
Why: Merge pull request #3123 from opensourcerouting/6.0-error-code-switch
[6.0] lib: add "log error-code" switch

Who: David Lamparter
Why: lib: add "log error-code" switch
Signed-off-by: David Lamparter <equinox@diac24.net>

Who: Donald Sharp
Why: lib: Include compiler.h as early as is possible in the build
The compiler.h header provides us with some useful macro"s
that we are using in the system.  We do not know exactly
where the CPP_NOTICE and CPP_WARN macros are used but
they can move around.  Place this header early in the
build then.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Who: Martin Winter
Why: FRRouting Release 6.0
Major Changes since 5.0:
- Staticd: New daemon responsible for management of static routes
- ISISd: Implement dst-src routing as per draft-ietf-isis-ipv6-dst-src-routing
- BFDd: new daemon for BFD (Bidrectional Forwarding Detection). Responsiblei
  for notifying link changes to make routing protocols converge faster.
- various bug fixes

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Manual run by Martin Winter
FRR-Pull-Requests
FRRouting
Tests: 6 of 5960 failed
Duration: 63 minutes
Changes: Who: Quentin Young
Why: Merge pull request #3338 from ton31337/fix/optional_args_for_exclude
bgpd: Optionally remove AS number when using `no set as-path exclude`
Custom build by Github Hook with revision master
FRR-RPKI
FRRouting
Tests: Testless build
Duration: 58 minutes
Changes: Who: Quentin Young
Why: Merge pull request #3338 from ton31337/fix/optional_args_for_exclude
bgpd: Optionally remove AS number when using `no set as-path exclude`
Changes by Quentin Young
OpenFabric
FRRouting
Tests: 6046 passed
Duration: 169 minutes
Changes: Who: David Lamparter
Why: isisd: silence SA warnings
As suggested by Renato Westphal.

Signed-off-by: David Lamparter <equinox@diac24.net>
Changes by David Lamparter
Snapcraft
FRRouting
Tests: 1323 passed
Duration: 920 minutes
Changes: Who: David Lamparter
Why: pimd: fix clang warning
pimd/pim_sock.c:178:13: error: implicit conversion from
        "int" to "char" changes value from 148 to -108
        [-Werror,-Wconstant-conversion]
    ra[0] = 148;

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Who: Jafar Al-Gharaibeh <Jafaral@users.noreply.github.com>
Why: Merge pull request #461 from donaldsharp/poll_2.0
Poll 2.0

Who: Donald Sharp
Why: lib: Rename HAVE_POLL to prevent conflicting #defines
Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with
snmp and poll enabled this was causing issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Who: Sam Tannous <stannous@cumulusnetworks.com>
Why: Remove uncalled function causing compiler error
Ticket: CM-16086
Reviewed By: sharpd
Testing Done: Built debs and tested on hardnode

With snmp enabled, this function was causing compiler
errors since it was not being called.  Removed it.

Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
Rebuilt by Martin Winter
TopoTest PullReq
7
FRRouting
Tests: 5 of 1240 failed
Duration: 44 minutes
Changes: Who: Rafael Zalamena <rzalamena@users.noreply.github.com>
Why: Merge pull request #140 from cfra/bugfix/fail-on-compile-error
bugfix: Fail on compile error

Who: Donald Sharp
Why: Merge pull request #3262 from mjstapp/clang_atomic_workaround
zebra: temporary workaround for a clang issue with atomics

Who: Renato Westphal
Why: ripd: retrofit the "timer basic" command to the new northbound model
Trivial conversion. Use the northbound "apply_finish()" callback so
we"ll call rip_event() only once even if we change the three RIP timers
at the same time.

Convert the timers to uint32_t to match their representation in the
YANG model.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

Who: Russ White <russ@riw.us>
Why: Merge pull request #3139 from adharkar/frr-bgp_cli
bgpd: BGP JSON show commands enhancements

Who: Martin Winter
Why: debianpkg: Add yang files to packages
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

...
Custom build by Github Hook with revision docker
Libyang github master
LIBYANG
Tests: Testless build
Duration: < 1 second
Changes: Who: Michal Vasko <mvasko@cesnet.cz>
Why: VERSION bump to version 0.16.77

Who: Michal Vasko <mvasko@cesnet.cz>
Why: data tree CHANGE do not remove empty containers during validation
Libyang Release
LIBYANG
Tests: Testless build
Duration: < 1 second
Changes: No changes
Manual run by Martin Winter
Temp libyang Build Test
LIBYANG
Tests: Testless build
Duration: 8 minutes
Changes: No changes
Manual run by Rafael Zalamena
RTRLIB
RPKI
Tests: Testless build
Duration: 8 minutes
Changes: Who: David Lamparter
Why: CMake: fix library installation path (#192)
The GNUInstallDirs CMake module expands CMAKE_INSTALL_LIBDIR to a full
path, which breaks the path munging in CMakeLists.txt.  In particular, a
build on i386 Debian gets the install paths wrong like this:

debian/tmp/build/librtr0-0.6.1.1/obj-i686-linux-gnu/lib/i386-linux-gnu/librtr.so.0.6.1
instead of
debian/tmp/usr/lib/i386-linux-gnu/librtr.so.0.6.1
Changes by David Lamparter