Tests: | Testless build |
---|---|
Duration: | 15 minutes |
Changes: | Who: Duncan Eastoe <duncan.eastoe@att.com> Why: zebra: reduce atomic ops in fpm_nl_process() Maintain the peak ctxqueue length in a local variable, and perform a single atomic update after processing all contexts. Generally this results in at least one less atomic operation per context. Signed-off-by: Duncan Eastoe <duncan.eastoe@att.com> Who: Donald Sharp <sharpd@nvidia.com> Why: pathd: Fix unlock of non-locked mutex We have several instances of a non-locked mutex being unlocked in path_zebra_router_id_update. Clean this up. Signed-off-by: Donald Sharp <sharpd@nvidia.com> Who: kuldeepkash <kashyapk@vmware.com> Why: tests: [topojson]Enhance lib/common_config.py to support PIM automation 1. Enhanced lib/common_config.py for common configuration/verification needed for PIM automation 2. Ran it through (black) for expected formatting Signed-off-by: kuldeepkash <kashyapk@vmware.com> Who: Russ White <russ@riw.us> Why: Merge pull request #7736 from ton31337/fix/s_addr_INADDR_ANY *: Replace s_addr check agains 0 with INADDR_ANY Who: Anuradha Karuppiah <anuradhak@cumulusnetworks.com> Why: zebra: accept bgp remote mac-ip update if the higher-seq-local mac is not bgp-ready If a local-MAC or local-neigh is not active locally it is not sent to BGP. At this point if BGP rxes a remote route it accepts it and installs in zebra. Zebra was rejecting BGP"s update if it had a higher seq local (inactive) entry. This would result in bgp and zebra falling out of sync. In some cases zebra would delete the local-inactive entries in sometime (as a part of the dplane/kernel garbage collection). This would leave zebra with missing remote entries (which were still present in bgpd). This change allows lower-seq BGP updates to overwrite zebra"s local entry if that entry happens to be local-inactive. Note: This logic was already in use for sync-mac-ip updates. Extended the same logic to remote-mac-ip updates. Ticket: CM-31626 Signed-off-by: Anuradha Karuppiah <anuradhak@cumulusnetworks.com> ... |
Tests: | 4 of 3701 failed |
---|---|
Duration: | 135 minutes |
Changes: | Who: David Lamparter Why: Merge pull request #6349 from qlyoung/hook-cpp-compat Who: Donald Sharp Why: zebra: Add code to install v6 blackhole routes on *bsd This code was just missing. Take the few minutes and get it done. ! ip route 4.5.6.7/32 Null0 ipv6 route 4::5/128 Null0 ! $ netstat -rn Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.122.1 UGS vtnet0 4.5.6.7/32 127.0.0.1 UG1B lo0 127.0.0.1 link#2 UH lo0 192.168.122.0/24 link#1 U vtnet0 192.168.122.40 link#1 UHS lo0 Internet6: Destination Gateway Flags Netif Expire ::/96 ::1 UGRS lo0 ::1 link#2 UH lo0 ::ffff:0.0.0.0/96 ::1 UGRS lo0 4::5/128 ::1 UG1B lo0 fe80::/10 ::1 UGRS lo0 fe80::%vtnet0/64 link#1 U vtnet0 fe80::5054:ff:fe5a:e705%vtnet0 link#1 UHS lo0 fe80::%lo0/64 link#2 U lo0 fe80::1%lo0 link#2 UHS lo0 ff02::/16 ::1 UGRS lo0 $ $ uname -a FreeBSD donna 12.1-RELEASE FreeBSD 12.1-RELEASE r354233 GENERIC amd64 $ Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #6365 from donaldsharp/bsd_v6_Null_bs zebra: Add code to install v6 blackhole routes on *bsd Who: Quentin Young Why: lib: make hook.h cpp-compatible Some CPP compilers don"t support these designated initializers, since we"re just zero initializing don"t need em Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com> Who: Donald Sharp Why: zebra: Remove the typedef netlink_nh_info_t Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> ... |
Tests: | 5914 passed |
---|---|
Duration: | 144 minutes |
Changes: | Who: Donald Sharp Why: Merge pull request #7504 from hohl/master docs: mention activate keyword in user docs |
Tests: | 2 of 5886 failed |
---|---|
Duration: | 111 minutes |
Changes: | Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #7566 from ton31337/fix/topotests_bgp_ebgp_requires_policy tests: Add more descriptive error messages and increase timeouts Who: Quentin Young <qlyoung@nvidia.com> Why: Revert "debian: Remove now obsolete tarsource.sh script" This reverts commit bc304e08ea48523b4c70d1d330eaefba3b6b7a6c. Who: Quentin Young <qlyoung@nvidia.com> Why: Revert "debian: Update the tools/build-debian-package.sh to be example build script" This reverts commit c950a7f214cd713652da1b6b78eca9278c33b448. Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #7424 from donaldsharp/config_commands lib, sharpd, vtysh: When reading a file in for config send start/end … Who: Quentin Young <qlyoung@nvidia.com> Why: Revert "debian: Update tools/build-debian-package.sh to use git-buildpackage" This reverts commit 63c0c8ed89e1564294ff174b819e520d5977f499. ... |
Tests: | 1 of 6150 failed |
---|---|
Duration: | 130 minutes |
Changes: | Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #7481 from donaldsharp/memory_options_are_long bgpd: Shorten some `show memory` strings |
Tests: | 9 of 949 failed |
---|---|
Duration: | 72 minutes |
Changes: | Who: Sri Mohana Singamsetty <srimohans@gmail.com> Why: Merge pull request #7164 from AnuradhaKaruppiah/mh-misc-fixes evpn-mh: miscellaneous cleanup/fixes |
Tests: | 1 of 4446 failed |
---|---|
Duration: | 263 minutes |
Changes: | No changes |
Tests: | 10765 passed |
---|---|
Duration: | 162 minutes |
Changes: | Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #7870 from donaldsharp/pytest_marking tests: Start the ability to mark tests |
Tests: | 438 passed |
---|---|
Duration: | 129 minutes |
Changes: | Who: Quentin Young Why: Merge pull request #3673 from opensourcerouting/60-bfd-24-hour 6.0: bfdd: Fix timer print-out function Who: David Lamparter Why: vtysh: fix pager compatibility handling I just straight up forgot checking VTYSH_PAGER at startup, and the "terminal paginate" command is only installed to VIEW_NODE so it can"t be processed from vtysh.conf in CONFIG_NODE... Signed-off-by: David Lamparter <equinox@diac24.net> Who: Quentin Young Why: *: 6.0.3 release * bgpd: Fix "show bgp ipv4/ipv6 neighbors" to show only v4 or v6 neighbors * bgpd: Fix display issue when showing labeled-unicast routes * bgpd: Fix incorrect # peers in "show bgp ipv6 summary" output * bgpd: Fix issue with remote-private-as in combination with local-as * bgpd: Fix memory error when prepending to AS-path * bgpd: Improve error handling when using maximum-prefix * ldpd: Fix startup permissions error on OpenBSD * ldpd: add support for FreeBSD IP_BINDANY * ospfd: Fix incorrect display of millisecond time values * tools: Fix incorrect systemd dependencies causing failure to start on boot * vtysh: Fix unnecessary reconnection under multi-instance OSPF * watchfrr: Fix multi-instance support when using new init script * zebra: Fix a display bug in "show ip route ... json" * zebra: Fix compilation issue on OpenBSD * zebra: Fix issue with missed selection of system-sourced routes * zebra: Fix race condition in label manager * zebra: Reliability improvements to pseudowire route recovery * zebra: Tweak metric values for macvlan devices Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com> Who: Donald Sharp Why: Merge pull request #3814 from opensourcerouting/6.0/doc-pager-theme [6.0] doc: VTYSH_PAGER docs + new FRR theme Who: Akhilesh Samineni <akhilesh.samineni@broadcom.com> Why: bgpd: Incorrect number of peers count in "show bgp ipv6 summary" output Fix : Now the peers count displays the number of neighbors activated per afi/safi. Signed-off-by: Akhilesh Samineni <akhilesh.samineni@broadcom.com> ... |
Tests: | Testless build |
---|---|
Duration: | 67 minutes |
Changes: | Who: Donald Sharp Why: Merge pull request #4182 from ton31337/fix/backslash_backport_for_as-path_filter_7.0 bgpd: [7.0] Allow backslash in as-path filter lists Who: Mark Stapp <mjs@voltanet.io> Why: lib: control privs changes with refcount Use a refcount to control privs changes. Support process-wide privs apis, as well as per-pthread apis. Double-commit of PR 4057. Signed-off-by: Mark Stapp <mjs@voltanet.io> Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #3961 from donaldsharp/connected_7.0 Connected 7.0 Who: Mark Stapp <mjs@voltanet.io> Why: lib: fix uninit and incorrect array-size in privs.c Double commit of PR 3805 to 7.0. Signed-off-by: Mark Stapp <mjs@voltanet.io> Who: David Lamparter Why: tools/frrcommon.sh: ignore "declare" failures The "declare -p watchfrr_options" call is just to support backwards compatibility. If it fails, silently ignore that. Signed-off-by: David Lamparter <equinox@diac24.net> ... |
Tests: | Testless build |
---|---|
Duration: | 63 minutes |
Changes: | Who: David Lamparter Why: FRRouting release 7.3.1 Maintenance/bugfix release. Signed-off-by: David Lamparter <equinox@opensourcerouting.org> |
Tests: | Testless build |
---|---|
Duration: | 89 minutes |
Changes: | Who: Martin Winter Why: FRRouting Release 7.4 BGPd Use sequence numbers for community lists Fixes to nexthop groups Add feature to limit outgoing number of routes Per Neighbor Graceful Restart Multiple Graceful Restart fixes Support sub-Type-4 and sub-Type-5 for the VPNv4 SRv6 backend rfc7606 support: treat certain malformed routes as withdraw allow origin override for route aggregates rfc6608 support: Subcodes for BGP Finite State Machine Error rfc7607 support: Codification of AS 0 Processing rfc6286 support: Autonomous-System-Wide Unique BGP Identifier for BGP-4 Unequal cost multipath (a.ka. weighted ECMP) with BGP link-bandwidth Enable rfc8212 by default except datacenter profile staticd Add debug support vtysh Add copy command to copy config from file into running config LDPd adding support for LDP ordered label distribution control ISISd IS-IS Segment Routing support SHARPd add initial support to add/remove lsps Zebra fix broadcast address in IPv4 networks with /31 mask Add Graceful Restart support for Protocol Daemon restarts lib migrate route-maps to use northbound interface plus countless bug fixes and other improvements Signed-off-by: Martin Winter <mwinter@opensourcerouting.org> |
Tests: | Testless build |
---|---|
Duration: | 39 minutes |
Changes: | Who: Martin Winter Why: FRRouting Release 7.5 BFD Profile support Minimum ttl support BGP rpki VRF support GR fixes Add wide option to display of routes Add `maximum-prefix <num> force` Add `bestpath-routes` to neighbor command Add `bgp shutdown message MSG...` command Add v6 Flowspec support Add `neighbor <neigh> shutdown rtt` command Allow update-delay to be applied globaly EVPN Beginning of MultiHoming Support ISIS Segment Routing Support VRF Support Guard against adj timer display overflow Add support for Anycast-SIDs Add support for Topology Independent LFA (TI-LFA) Add `lsp-gen-interval 2` to isis configuration OSPF Segment Routing support for ECMP Various LSA fixes Prevent crash if transferring config amongst instances PBR Adding json support to commands DSCP/ECN based PBR Matching PIM Add more json support to commands Fix missing mesh-group commands MSDP SA forwarding Clear (s,g,rpt) ifchannel on (*, G) prune received Fix igmp querier election and IP address mapping Crash fix when RP is removed STATIC Northbound Support YANG Filter and route-map Support OSPF model definition BGP model definition VTYSH Speed up output across daemons Fix build-time errors for some --enable flags Speed up output of configuration across daemons ZEBRA nexthop group support for FPM northbound support for rib model Backup nexthop support netlink batching support Allow upper level protocols to request ARP Add json output for zebra ES, ES-EVI and access vlan dumps Upgrade to using libyang1.0.184 RPM Moved RPKI to subpackage Added SNMP subpackage As always there are too many bugfixes to list individually. This release compromises just over 1k of commits by the community, with contributors from 70 people. Signed-off-by: Martin Winter <mwinter@opensourcerouting.org> |
Tests: | 1322 passed |
---|---|
Duration: | 962 minutes |
Changes: | Who: Donald Sharp Why: Merge pull request #3577 from LabNConsulting/working/6.0/no-bgp-attr-255 6.0: bgpd: don"t use BGP_ATTR_VNC(255) unless ENABLE_BGP_VNC_ATTR is defined Who: Lou Berger Why: bgpd: don"t use BGP_ATTR_VNC(255) unless ENABLE_BGP_VNC_ATTR is defined Signed-off-by: Lou Berger <lberger@labn.net> Who: Martin Winter Why: FRRouting Release 6.0.2 This is a maintenance release for a security (Denial of Service) issue found with the expermimental BGP VNC Attribute (255). Other experiments using the same attribute may bring down BGP peers if they are malformed for the VNC parsing. (As required by RFC). The update disables the parsing of the VNC attribute by default to avoid this. Beside this change, this release is similar to 6.0.1 Major Changes since 6.0 (already in 6.0.1) - New Debian Package structure without backports - Fix Memory Leak on FreeBSD - Fix BGP unnumbered peer setup - Various fixes for label manager - Various other fixes Signed-off-by: Martin Winter <mwinter@opensourcerouting.org> |
Tests: | 1499 passed |
---|---|
Duration: | 958 minutes |
Changes: | Who: Donatas Abraitis <donatas.abraitis@gmail.com> Why: bgpd: Show `ip` and `fqdn` in json output for `show [ip] bgp <route> json` This should keep backward compatibility when bgp show-hostname is enabled/disabled. Also show the real originator IP instead of showing fqdn of the route reflector. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com> Who: Donatas Abraitis <donatas.abraitis@gmail.com> Why: doc: redistribute vpn --> redistribute vnc Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com> Who: Mark Stapp <mjs@voltanet.io> Why: zebra: use correct state when installing evpn macs [7.2 version] Use correct state/flags when installing EVPN macs; when we converted from raw netlink to the zebra dataplane, a state value got lost. Signed-off-by: Mark Stapp <mjs@voltanet.io> Who: Quentin Young Why: bgpd: ensure transit ptr is nulled on free Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com> Who: Donatas Abraitis <donatas.abraitis@gmail.com> Why: bgpd: Reflect the distance in RIB when it is changed for an arbitrary afi/safi debian-9# show ip route 192.168.255.2/32 longer-prefixes Codes: K - kernel route, C - connected, S - static, R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP, T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP, F - PBR, f - OpenFabric, > - selected route, * - FIB route, q - queued route, r - rejected route B>* 192.168.255.2/32 [20/0] via 192.168.0.1, eth1, 00:15:22 debian-9# conf debian-9(config)# router bgp 100 debian-9(config-router)# address-family ipv4 debian-9(config-router-af)# distance bgp 123 123 123 debian-9(config-router-af)# do show ip route 192.168.255.2/32 longer-prefixes Codes: K - kernel route, C - connected, S - static, R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP, T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP, F - PBR, f - OpenFabric, > - selected route, * - FIB route, q - queued route, r - rejected route B>* 192.168.255.2/32 [123/0] via 192.168.0.1, eth1, 00:00:09 debian-9(config-router-af)# no distance bgp debian-9(config-router-af)# do show ip route 192.168.255.2/32 longer-prefixes Codes: K - kernel route, C - connected, S - static, R - RIP, O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP, T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP, F - PBR, f - OpenFabric, > - selected route, * - FIB route, q - queued route, r - rejected route B>* 192.168.255.2/32 [20/0] via 192.168.0.1, eth1, 00:00:02 debian-9(config-router-af)# Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com> ... |
Tests: | 1 of 11099 failed |
---|---|
Duration: | 162 minutes |
Changes: | Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #7870 from donaldsharp/pytest_marking tests: Start the ability to mark tests |
Tests: | 6046 passed |
---|---|
Duration: | 169 minutes |
Changes: | Who: David Lamparter Why: isisd: silence SA warnings As suggested by Renato Westphal. Signed-off-by: David Lamparter <equinox@diac24.net> |
Tests: | 1323 passed |
---|---|
Duration: | 920 minutes |
Changes: | Who: David Lamparter Why: pimd: fix clang warning pimd/pim_sock.c:178:13: error: implicit conversion from "int" to "char" changes value from 148 to -108 [-Werror,-Wconstant-conversion] ra[0] = 148; Signed-off-by: David Lamparter <equinox@opensourcerouting.org> Who: Jafar Al-Gharaibeh <Jafaral@users.noreply.github.com> Why: Merge pull request #461 from donaldsharp/poll_2.0 Poll 2.0 Who: Donald Sharp Why: lib: Rename HAVE_POLL to prevent conflicting #defines Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with snmp and poll enabled this was causing issues. Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com> Who: Sam Tannous <stannous@cumulusnetworks.com> Why: Remove uncalled function causing compiler error Ticket: CM-16086 Reviewed By: sharpd Testing Done: Built debs and tested on hardnode With snmp enabled, this function was causing compiler errors since it was not being called. Removed it. Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com> |
Tests: | 5 of 620 failed |
---|---|
Duration: | 47 minutes |
Changes: | Who: Christian Franke Why: Fix README update Who: Russ White <russ@riw.us> Why: Merge pull request #4031 from nitinsoniism/show_evpn_route_vni_all_detail bgpd: new show cmd - bgp l2vpn evpn route vni all detail Who: Renato Westphal <renato@openbsd.org> Why: Merge pull request #4085 from donaldsharp/zebra_nht_individual_items zebra: Allow specification of v[4|6] addrs on some commands Who: Donald Sharp Why: Merge pull request #4095 from pacovn/201904_master__lm_aliasing_fixes zebra: label manager race condition fix Who: Mark Stapp <mjs@voltanet.io> Why: Merge pull request #4132 from opensourcerouting/northbound-debug lib: add fine-grained debugging in the northbound ... |
Tests: | Testless build |
---|---|
Duration: | 16 minutes |
Changes: | Who: Martin Winter Why: packages: Make RPM package options same as official Debian Pkg options Signed-off-by: Martin Winter <mwinter@opensourcerouting.org> |
Tests: | Testless build |
---|---|
Duration: | 27 minutes |
Changes: | Who: tmtom <tomasamot@gmail.com> Why: xpath BUGFIX prevent debug buffer overflow (#1301) |