FRR
FRRouting
Tests: 2 of 7717 failed
Duration: 108 minutes
Changes: Who: Quentin Young
Why: Merge pull request #2625 from pguibert6WIND/ipv4_ipv6_bgp_show
doc: add more information about show ip bgp and show bgp
Changes by Quentin Young
FRR Release 2.0 Build
FRRouting
Tests: 346 passed
Duration: 69 minutes
Changes: No changes
Manual run by Martin Winter
FRR Release 3.0 Build
FRRouting
Tests: 383 passed
Duration: 79 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR Release 4.0 Build
FRRouting
Tests: 412 passed
Duration: 83 minutes
Changes: No changes
Manual run by Martin Winter
FRR Release 5.0 Build
FRRouting
Tests: 421 passed
Duration: 133 minutes
Changes: Who: Philippe Guibert
Why: zebra: add show pbr iptable dscp information
The iptable configured with dscp displays the dscp value configured.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Philippe Guibert
Why: bgpd: fix recursive call combination
The recursive algorithm was taking into account the fact that all the
bpof structures were filled in. Because the dscp value was not given,
the pkt_len parsing could not be achieved. Now the iteration takes into
account each type according to the previous one, thus guaranting all
parameters to be parsed.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Pascal Mathis <mail@pascalmathis.com>
Why: bgpd: Fix AF-attribute overrides when binding peer
The current implementation of the overrides for peer address-family
attributes suffered a bug, which caused all peer-specific attributes to
be lost when the peer was added to a peer-group which already had that
specific address-family active.

This commit extends the *peer_group2peer_config_copy_af* function to
respect overridden flags properly. Additionally, the arguments of the
macros *PEER_ATTR_INHERIT* and *PEER_STR_ATTR_INHERIT* have been
reordered to be more consistent and easy to read.

This commit also adds further test cases to the BGP peer attributes test
suite, so that this kind of error is being caught in future commits. The
missing AF-attribute *distribute-list* has also been added to the test
suite.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>
(cherry picked from commit e7103a9644f32a70a10be8f6372aa9084aa33c2f)

Who: Philippe Guibert
Why: bgpd: align fragment flowspec decoding with tcpflags
As fragment bitmask and tcpflags bitmask in flowspec protocol is encoded
in the same way, it is not necessary to differentiate those two fields.
Moreover, it overrides the initial fragment limit set to 1. It is now
possible to handle multiple framgent values.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

Who: Philippe Guibert
Why: bgpd: handle ICMP type and code from flowspec
It is possible for flowspec entries containing ICMP rule to insert PBR
entries based on ICMP type and ICMP code.
Flowspec ICMP filtering can either have icmp type or icmp code or both.
Not all combinations are permitted:
- if icmp code is provided, then it is not possible to derive the
  correct icmp value. This will not be installed
- range of ICMP is authorised or list of ICMP, but not both.
- on receiving a list of ICMPtype/code, each ICMP type is attempted to
  be associated to ICMP code. If not found, then ICMPtype is combined
  with all known ICMP code values associated to that ICMP type.
- if a specific ICMP type/code is needed, despite the ICMP code/type
  combination does not exist, then it is possible to do it by forging a
  FS ICMP type/code specific for that.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

...
Manual run by Martin Winter
FRR-3.0-Snapcraft
FRRouting
Tests: 1322 passed
Duration: 934 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR-4.0-Snapcraft
FRRouting
Tests: 1322 passed
Duration: 944 minutes
Changes: No changes
Rebuilt by Martin Winter
FRR-Pull-Requests
FRRouting
Tests: 6676 passed
Duration: 55 minutes
Changes: Who: Quentin Young
Why: Merge pull request #2625 from pguibert6WIND/ipv4_ipv6_bgp_show
doc: add more information about show ip bgp and show bgp
Custom build by Github Hook with revision master
FRR-RPKI
FRRouting
Tests: Testless build
Duration: 54 minutes
Changes: Who: Quentin Young
Why: Merge pull request #2625 from pguibert6WIND/ipv4_ipv6_bgp_show
doc: add more information about show ip bgp and show bgp
Changes by Quentin Young
OpenFabric
FRRouting
Tests: 4199 passed
Duration: 161 minutes
Changes: No changes
Manual run by Martin Winter
Snapcraft
FRRouting
Tests: 1323 passed
Duration: 920 minutes
Changes: Who: David Lamparter
Why: pimd: fix clang warning
pimd/pim_sock.c:178:13: error: implicit conversion from
        "int" to "char" changes value from 148 to -108
        [-Werror,-Wconstant-conversion]
    ra[0] = 148;

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Who: Jafar Al-Gharaibeh <Jafaral@users.noreply.github.com>
Why: Merge pull request #461 from donaldsharp/poll_2.0
Poll 2.0

Who: Donald Sharp
Why: lib: Rename HAVE_POLL to prevent conflicting #defines
Rename HAVE_POLL to HAVE_POLL_CALL, when compiling with
snmp and poll enabled this was causing issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Who: Sam Tannous <stannous@cumulusnetworks.com>
Why: Remove uncalled function causing compiler error
Ticket: CM-16086
Reviewed By: sharpd
Testing Done: Built debs and tested on hardnode

With snmp enabled, this function was causing compiler
errors since it was not being called.  Removed it.

Signed-off-by: Sam Tannous <stannous@cumulusnetworks.com>
Rebuilt by Martin Winter
TopoTest PullReq
FRRouting
Tests: 1 of 873 failed
Duration: 30 minutes
Changes: Who: Rafael Zalamena <rzalamena@users.noreply.github.com>
Why: Merge pull request #105 from LabNConsulting/working/minor-lib-improvements2
improve logging, fix (false) intermittent timing related failure in bgp_l3vpn_to_bgp_vrf

Who: Quentin Young
Why: Merge pull request #2469 from ajones-rvbd/ajones-issue-2442
unit tests: support code coverage instrumentation and reports

Who: Quentin Young
Why: Merge pull request #2628 from pguibert6WIND/realpath_debug
lib: add the pathname to get the realpath in case of failure

Who: Donald Sharp
Why: Revert "lib: A small optimization for the hash iterate and walk functions"
This reverts commit fc61644e440c875eefa222ab34d726c6281ca806.

Who: Philippe Guibert
Why: zebra: upon RTM_NEWROUTE/DELROUTE, find appropriate interface
The interface lookup algorithm is different according to if we are on
netns vrf or not. If we are on the former case, then we only have to
parse the interfaces of the netns, while if we are on the other case, we
have to parse all the interfaces of all the vrfs ( since index is not
overlapping in the latter case).

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

...
Custom build by Github Hook with revision master
MASTER
5
QUAGGA
Tests: Testless build
Duration: 55 minutes
Changes: Who: Balaji Gurudoss <balajig81@gmail.com>
Why: Bumped up the version to 1.2.2
PATCHWORK
QUAGGA
Tests: 2539 passed
Duration: 53 minutes
Changes: No changes
Rebuilt by Martin Winter
QUAGGA-RPKI
QUAGGA
Tests: Testless build
Duration: 49 minutes
Changes: Who: Marcel Röthke <marcel.roethke@haw-hamburg.de>
Why: Implement atomic reset (#165)
* implement atomic update for pfx table

* implement atomic reset of spki table

* add spki diff/swap test cases and improve pfx test case

* fix typo

* pfx: move structs to the top of the file

* spki: fix logic error in copy_table_except_spocket

* pfx: spki: fix some docstrings

* spki: implement missing spki_table_free_without_notify function

* tests: small print optimization

* spki: fix coding style

* pfx: add error handling for pfx_table_copy_except_socket
QUAGGA-RPKI-DISABLED
QUAGGA
Tests: 2532 passed
Duration: 51 minutes
Changes: Who: Colin Sames <sames.colin@gmail.com>
Why: Build Quagga without SSH support of RTRlib
If the RTRlib was compiled without SSH support, check certain blocks of code whether they
should be compiled or not. This is experimental and most certainly causes unexpected
behavior. Compiles without errors on Ubuntu 16.04.

Who: Colin Sames <sames.colin@gmail.com>
Why: Merge branch "feature/rtrlib" of https://github.com/ColinBS/quagga-rtrlib into feature/rtrlib

Who: Andreas Reuter <andreas.router@googlemail.com>
Why: Merge pull request #6 from ColinBS/feature/rtrlib
Build Quagga without SSH support of RTRlib
RTRLIB
RPKI
Tests: Testless build
Duration: 8 minutes
Changes: Who: Marcel Röthke <marcel.roethke@haw-hamburg.de>
Why: Implement atomic reset (#165)
* implement atomic update for pfx table

* implement atomic reset of spki table

* add spki diff/swap test cases and improve pfx test case

* fix typo

* pfx: move structs to the top of the file

* spki: fix logic error in copy_table_except_spocket

* pfx: spki: fix some docstrings

* spki: implement missing spki_table_free_without_notify function

* tests: small print optimization

* spki: fix coding style

* pfx: add error handling for pfx_table_copy_except_socket